Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] The dnssd advertises VID and PID if extended announcement is enabled #35592

Open
kkasperczyk-no opened this issue Sep 16, 2024 · 0 comments
Labels
bug Something isn't working needs triage

Comments

@kkasperczyk-no
Copy link
Contributor

Reproduction steps

The extended announcement feature, per spec, requires to not include VID and PID in the advertisement data, to keep the user privacy (5.4.2.3.1):

If a device opts to use Extended Announcement, it SHALL set both the PID and VID to 0 in the
announcement and SHALL elide any Extended Data. This is to preserve user privacy for scenarios
where a device may remain uncommissioned for extended periods.

This feature can be enabled for dnssd through the CHIP_DEVICE_CONFIG_EXT_ADVERTISING define, but the implementation only allows to use the bigger value of advertising duration, however it does not change the content of advertised data (excludes VID and PID).

The suggested solution could be to follow the BLE implementation that runs the timer and after 15 minutes it updated the advertised data content.

Bug prevalence

Always

GitHub hash of the SDK that was being used

a068855

Platform

core

Platform Version(s)

No response

Anything else?

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs triage
Projects
None yet
Development

No branches or pull requests

1 participant