Skip to content

Commit 362687e

Browse files
ralyodioclaude
andcommitted
Fix CI: commit pnpm-lock.yaml + install ffmpeg/imagemagick in test workflow
The sh1pt test workflow uses `cache: pnpm` + `pnpm install --frozen-lockfile`, which require a committed lockfile, but .gitignore excluded pnpm-lock.yaml — so the job failed with "Dependencies lock file is not found". The test suite also shells out to ffmpeg/ffprobe and ImageMagick, which aren't on the runner. - Stop gitignoring pnpm-lock.yaml and commit it (pnpm 10.6.5) - Add an apt install step for ffmpeg + imagemagick to test.yml Verified locally: 85 passing, 12 pending, 0 failing. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
1 parent 182bbd3 commit 362687e

3 files changed

Lines changed: 696 additions & 1 deletion

File tree

.github/workflows/test.yml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,11 @@ jobs:
1919
steps:
2020
- uses: actions/checkout@v4
2121

22+
# The test suite shells out to ffmpeg/ffprobe and ImageMagick's convert;
23+
# install them so the integration tests can run on the runner.
24+
- name: Install FFmpeg and ImageMagick
25+
run: sudo apt-get update && sudo apt-get install -y ffmpeg imagemagick
26+
2227
# pnpm version is read from the "packageManager" field in package.json.
2328
# Do not pin a version here — it conflicts with packageManager and fails
2429
# with ERR_PNPM_BAD_PM_VERSION.

.gitignore

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ yarn-debug.log*
88
yarn-error.log*
99
.pnpm-debug.log*
1010

11-
pnpm-lock.yaml
1211
ffmpeg_build/
1312

1413
# Environment variables

0 commit comments

Comments
 (0)