ShowIf conditions fail if the dependent field is locked

[adrianbj]

Short description of the issue

If there is a showIf condition that looks something like: registration_type!=1643 on a field, it won't show if the registration_type field is locked, regardless of whether its value is 1643 or not.

Note this in this case, registration_type is a page field with a "select" inputfield.

Expected behavior

A field being locked shouldn't affect showIf conditions.

NB - this may be related to: #780 but not certain.

[ryancramerdesign]

A showIf condition cannot work on a locked field, because a locked field has no inputs rendered in the form for a showIf condition to evaluate. The purpose of a locked field is just to show the value rather than to provide a means of editing it, so locked fields aren't ones that you can use with dependencies.

[adrianbj]

I know you can't currently use showIf with locked fields, but I guess this is really a feature request because I think it would be a very useful addition. I don't think there is any notes / docs to point out that it doesn't work.

Would you be willing to consider supporting it?

[adrianbj]

Hi @ryancramerdesign - just wondering if you might have had any thoughts about this. I'm in a bit of a bind trying to lock certain fields from being edited, but because they have showIf conditions attached, the connected fields aren't visible when they should be.

[adrianbj]

Hi again @ryancramerdesign - there is actually more to this. The same problem happens if you make use of field level access control. So if you prevent a user from editing a field, then it hides the the field with a showIf rule that needs the value from the access controlled field.

[Toutouwai]

Below is a possible way this could be implemented. @adrianbj this could perhaps be used as a short-term workaround, and @ryancramerdesign maybe this idea could be adopted into the core.

$wire->addHookAfter('Inputfield::renderValue', function(HookEvent $event) {
    /** @var Inputfield $inputfield */
    $inputfield = $event->object;
    $value = (string) $inputfield->value;
    $class = '';
    if($inputfield instanceof InputfieldPage) {
        $class = " class='InputfieldPage'";
        $value = str_replace('|', ',', $value);
    }
    $event->return .= "<textarea id='$inputfield->id' style='display:none !important;'$class>$value</textarea>";
});

I haven't tested every operator on every inputfield type but it seems to work well for everything I did try.

To support "count" selectors it needs a small change to inputfields.js. This line...

if (condition.subfield == 'count') value = value.length;

...is removed and the following line is added at line 1348...

if (condition.subfield == 'count') values[0] = values.length;

[adrianbj]

@Toutouwai - awesome as always, thank you :)

That does seem to solve things very nicely.

@ryancramerdesign - any chance of implementing this in the core please?

[adrianbj]

I was coming up agains an issue with checkboxes from an options select fieldtype. This takes care of it and hopefully other similar situations where the inputfield value is an array.

$this->wire()->addHookAfter('Inputfield::renderValue', function(HookEvent $event) {
    /** @var Inputfield $inputfield */
    $inputfield = $event->object;
    if(is_array($inputfield->value)) {
        $value = implode(',', $inputfield->value);
    }
    else {
        $value = (string) $inputfield->value;
    }
    $class = '';
    if($inputfield instanceof InputfieldPage) {
        $class = " class='InputfieldPage'";
        $value = str_replace('|', ',', $value);
    }
    $event->return .= "<textarea id='$inputfield->id' style='display:none !important;'$class>$value</textarea>";
});

[Toutouwai]

I just discovered that unfortunately this approach doesn't work for inputfields inside Repeater fields rendered in renderValue mode. The data-show-if attribute isn't included in the markup in this case.