Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discussion: Is it OK to not support previous VerifyingKey versions? #267

Closed
ed255 opened this issue Feb 2, 2024 · 0 comments
Closed

Discussion: Is it OK to not support previous VerifyingKey versions? #267

ed255 opened this issue Feb 2, 2024 · 0 comments
Labels
wontfix This will not be worked on

Comments

@ed255
Copy link
Member

ed255 commented Feb 2, 2024 •
edited
Loading

From here:

halo2/halo2_proofs/src/plonk.rs

Line 123 in 73408a1

if VERSION != version_byte[0] {

In halo2, whenever an update changes the VeriyingKey type in a non forward-compatible manner we're supposed to bump the version. When reading a serialized VerifyingKey, older versions are rejected.

I think supporting multiple versions could add a lot of complexity, but we can discuss this.

Discussion from #254 (comment)
@ed255 ed255 mentioned this issue Feb 2, 2024
Merged
15 tasks
@davidnevadoc davidnevadoc added the wontfix This will not be worked on label Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
wontfix This will not be worked on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@davidnevadoc @ed255