Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dataproxy/vercel-edge-functions should include edge runtime route #3879

Open
rtbenfield opened this issue Aug 31, 2023 · 1 comment
Open
Labels
kind/feature A request for a new feature. topic: vercel

Comments

@rtbenfield
Copy link

rtbenfield commented Aug 31, 2023

We discovered an issue with @prisma/extension-accelerate where vercel deploy would fail for Edge Function deployments with an error message regarding it's ability to resolve the package entrypoint. This was not an issue for Next.js edge functions; only for "other" runtime edge functions. We were able to work with the Vercel team to identify the issue. I came back to review the ecosystem test here to understand why it was undetected.

Our current tests in dataproxy/vercel-edge-functions use a Serverless API route and not a route configured with runtime: "edge". This resulted in the vercel deploy compatibility checks not validating the extension package for edge compatibility.

Would it make sense to incorporate an edge API route into the existing test structure in addition to the serverless route?

@janpio
Copy link
Contributor

janpio commented Aug 31, 2023

I think dataproy/vercel-edge-functions actually tests Edge Functions via Edge Middleware, and the serverless function does nothing with Prisma.

So we should rename that project, and add one that actually uses an explicit edge function that uses Prisma.

@janpio janpio added the kind/feature A request for a new feature. label Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature A request for a new feature. topic: vercel
Projects
None yet
Development

No branches or pull requests

3 participants