Extract ResponsiveValue types from useResponsiveValue hook to SSR-safe module #7432
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PageLayout and SplitPageLayout imported
ResponsiveValuetypes fromhooks/useResponsiveValue, creating ambiguity about whether they use the SSR-unsafe hook. These components already follow ADR-018's CSS-based responsive pattern, never callinguseResponsiveValue(), but the import structure obscured this.Changes
Extracted SSR-safe types and utilities to dedicated module:
internal/utils/responsiveTypes.tswithResponsiveValue,FlattenResponsiveValue, andisResponsiveValueuseResponsiveValue.tsisResponsiveValuetype guardBefore:
After:
Changelog
New
internal/utils/responsiveTypes.ts- SSR-safe module for responsive types and utilities with comprehensive JSDocChanged
responsiveTypesinstead ofuseResponsiveValuegetResponsiveAttributesandgetResponsiveControlValuesimport from new moduleisResponsiveValuenow properly handles null/undefined valuesRemoved
Rollout strategy
No breaking changes. All existing imports continue to work through re-exports.
Testing & Reviewing
Verify PageLayout responsive props work correctly:
Check that data attributes are correctly applied and CSS media queries handle responsiveness without hydration mismatches.
Merge checklist
Original prompt
This pull request was created from Copilot chat.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.