Update recommended.js (#331)

francinelucca · web-flow · commit 82a7d037b92c · 2025-04-24T13:10:21.000-04:00
* Update recommended.js

* update rule message

* Create honest-adults-add.md

* Create eighty-tips-deliver.md

* disable lint rule
diff --git a/.changeset/eighty-tips-deliver.md b/.changeset/eighty-tips-deliver.md
@@ -0,0 +1,5 @@
+---
+"eslint-plugin-primer-react": patch
+---
+
+Update message for no-deprecated-experimental-components rule
diff --git a/.changeset/honest-adults-add.md b/.changeset/honest-adults-add.md
@@ -0,0 +1,5 @@
+---
+"eslint-plugin-primer-react": patch
+---
+
+Removes primer-react/enforce-css-module-identifier-casing, primer-react/enforce-css-module-default-import from recommended set of rules.
diff --git a/package-lock.json b/package-lock.json
diff --git a/src/configs/recommended.js b/src/configs/recommended.js
@@ -22,8 +22,6 @@ module.exports = {
     'primer-react/a11y-use-accessible-tooltip': 'error',
     'primer-react/no-unnecessary-components': 'error',
     'primer-react/prefer-action-list-item-onselect': 'error',
-    'primer-react/enforce-css-module-identifier-casing': 'error',
-    'primer-react/enforce-css-module-default-import': ['error', {enforceName: '(^classes$|Classes$)'}],
   },
   settings: {
     github: {
diff --git a/src/rules/__tests__/no-deprecated-experimental-components.test.js b/src/rules/__tests__/no-deprecated-experimental-components.test.js
@@ -30,14 +30,14 @@ ruleTester.run('no-deprecated-experimental-components', rule, {
     {
       code: `import {SelectPanel} from '@primer/react/experimental'`,
       errors: [
-        'SelectPanel is deprecated. Please import from the stable entrypoint (@primer/react) if available, or check https://primer.style/product/components/ for alternative components.',
+        'The experimental SelectPanel is deprecated. Please import from the stable entrypoint (@primer/react) if available, or check https://primer.style/product/components/ for alternative components.',
       ],
     },
     // Multiple experimental import
     {
       code: `import {SelectPanel, DataTable, ActionBar} from '@primer/react/experimental'`,
       errors: [
-        'SelectPanel is deprecated. Please import from the stable entrypoint (@primer/react) if available, or check https://primer.style/product/components/ for alternative components.',
+        'The experimental SelectPanel is deprecated. Please import from the stable entrypoint (@primer/react) if available, or check https://primer.style/product/components/ for alternative components.',
       ],
     },
   ],
diff --git a/src/rules/no-deprecated-experimental-components.js b/src/rules/no-deprecated-experimental-components.js
@@ -52,7 +52,8 @@ module.exports = {
         }
 
         if (experimental.length > 0) {
-          const message = `${components.join(', ')} ${
+          // eslint-disable-next-line i18n-text/no-en
+          const message = `The experimental ${components.join(', ')} ${
             components.length > 1 ? 'are' : 'is'
           } deprecated. Please import from the stable entrypoint (@primer/react) if available, or check https://primer.style/product/components/ for alternative components.`
 

Original file line number	Diff line number	Diff line change
`@@ -52,7 +52,8 @@ module.exports = {`
`52`	`52`	`}`
`53`	`53`
`54`	`54`	`if (experimental.length > 0) {`
`55`		- const message = `${components.join(', ')} ${
	`55`	`+ // eslint-disable-next-line i18n-text/no-en`
	`56`	+ const message = `The experimental ${components.join(', ')} ${
`56`	`57`	`components.length > 1 ? 'are' : 'is'`
`57`	`58`	} deprecated. Please import from the stable entrypoint (@primer/react) if available, or check https://primer.style/product/components/ for alternative components.`
`58`	`59`