Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[a11y] SubNav links unaccessible on 200% zoom #845

Open
stamat opened this issue Dec 2, 2024 · 0 comments
Open

[a11y] SubNav links unaccessible on 200% zoom #845

stamat opened this issue Dec 2, 2024 · 0 comments
Assignees
Labels
brand bug Something isn't working

Comments

@stamat
Copy link
Contributor

stamat commented Dec 2, 2024

Links are not accessible at all when the page is zoomed to 200% and the height of the window is small. Try it out on 320x256 screen size.

Issue is present on the current /features page where SubNav is used instead of the AnchorNav since the latter can support only few links (also a thing to look at).

A11y audit marked this issue as Sev 2

I've placed an override in this PR: https://github.com/github/github/pull/353042

.lp-SubNav {
  padding: 0;
  overflow-y: auto;
  max-height: 100vh;
  min-height: 56px;

  ul {
    padding: var(--base-size-16);
    background-color: var(--brand-color-canvas-default);

    @media screen and (min-width: 1012px) {
      padding: var(--base-size-20) var(--base-size-32);
      background: none;
    }
  }
}

I know that we are making a SubNav v2 but we need to make sure that this issue doesn't persist.

@rezrah rezrah added the brand label Dec 2, 2024
@rezrah rezrah self-assigned this Dec 2, 2024
@stamat stamat added the bug Something isn't working label Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
brand bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants