Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [BUG] - Visual issue with SubNav underline #789

Open
stamat opened this issue Oct 15, 2024 · 0 comments · May be fixed by #794
Open

🐛 [BUG] - Visual issue with SubNav underline #789

stamat opened this issue Oct 15, 2024 · 0 comments · May be fixed by #794
Labels
brand bug Something isn't working

Comments

@stamat
Copy link
Contributor

stamat commented Oct 15, 2024

Describe the bug

SubNav items underline renders weirdly when the text breaks in two lines on "pre tablet" screen sizes. Making the span wrapper that contains :after underline display: block; position: relative; solves the issue.

.lp-SubNav li > a > span {
  display: block;
  position: relative;
}

Reproduction steps

On tablet screen sizes when there are a lot of items with a lot of text the underline misbehaves. The issue can be reproduced on https://github.com/features

Expected behavior

Underline spans full width of the SubNav.Item

Screenshots

Current behavior
Image
Expected behavior
Image

Browsers

No response

OS

No response

@stamat stamat added the bug Something isn't working label Oct 15, 2024
@raytalks raytalks added the brand label Oct 18, 2024
@joshfarrant joshfarrant linked a pull request Oct 23, 2024 that will close this issue
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
brand bug Something isn't working
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

2 participants