Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component Name: "Dialog" Issue Title: Unexpected behavior with speciffic set of Dialog props #6922

Open
borisragaji opened this issue Dec 4, 2024 · 1 comment
Labels
Resolution: Help Wanted Issue or pull request requires extra help and feedback

Comments

@borisragaji
Copy link

Describe the bug

Following API documentation from the https://primevue.org/dialog/#api.dialog.props I faced with unexpected behavior of Dialog component.
I wanted to use Dialog: without closable button "X", with possibility to close Dialog on Escape button, also on clicking to the background which is disabled using modal prop. Removing "X" button will block functionality of the Escape button and focus will be lost in background until components within Dialog comes to their turn to be focused.

Reproducer

https://stackblitz.com/edit/primevue-nuxt-issue-template-4yg7uf?file=app.vue

PrimeVue version

^4.1.1

Vue version

4.x

Language

TypeScript

Build / Runtime

Nuxt

Browser(s)

Firefox 133.0

Steps to reproduce the behavior

First case

  1. Click on "Show" button
  2. Try to close Dialog clicking Escape button

Second case

  1. Click on "Show" button
  2. Click Tab button to change focus -> it will goes to the table instead of the components within the Dialog

Expected behavior

Removing "X" button from the dialog with Dialog prop "closable", I want to be able to use Escape button and it's behavior (closing dialog). Also, after opening the Dialog, I expect to focus be inside of the Dialog on very start, not to go outside of it.

Thanks for everything! :-)

@borisragaji borisragaji added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Dec 4, 2024
@tugcekucukoglu tugcekucukoglu added Resolution: Help Wanted Issue or pull request requires extra help and feedback and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Dec 10, 2024
Copy link

Due to PrimeVue team's busy roadmap, this issue is available for anyone to work on. Make sure to reference this issue in your pull request. ✨ Thank you for your contribution! ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution: Help Wanted Issue or pull request requires extra help and feedback
Projects
None yet
Development

No branches or pull requests

2 participants