Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Select: aria-invalid attribute missing in non-editable mode #6813

Open
arpi17 opened this issue Nov 19, 2024 · 0 comments · May be fixed by #6814
Open

Select: aria-invalid attribute missing in non-editable mode #6813

arpi17 opened this issue Nov 19, 2024 · 0 comments · May be fixed by #6814
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone
4.3.0

Comments

@arpi17
Copy link

arpi17 commented Nov 19, 2024

Describe the bug

In non-editable mode the Select component doesn't have the aria-invalid="true" attribute when the invalid property is set on it. In editable mode the attribute is correctly set when setting the invalid property.

This attribute would be nice to have also in non-editable mode since it not just improves screen reader support but also enables styling the component in pure unstyled mode (since now in pure unstyled mode setting the invalid property in non-editable mode does not have any effect on the component)

Reproducer

https://stackblitz.com/edit/primevue-4-vite-issue-template-trdk6i?file=src%2FApp.vue

PrimeVue version

4.2.2

Vue version

3.x

Language

ALL

Build / Runtime

Vue CLI App

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response
@arpi17 arpi17 added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Nov 19, 2024
@arpi17 arpi17 linked a pull request Nov 19, 2024 that will close this issue
Open
@tugcekucukoglu tugcekucukoglu added Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Nov 21, 2024
@tugcekucukoglu tugcekucukoglu added this to the 4.3.0 milestone Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
PrimeVue
Status: No status
Milestone
4.3.0
Development

Successfully merging a pull request may close this issue.

fix(Select): Set aria-invalid attribute in non-editable mode as well arpi17/primevue
2 participants
@arpi17 @tugcekucukoglu