Skip to content

misc: Make event loop THE implementation for httpRemoteTask and related code #26697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shangm2 merged 1 commit into from
Dec 2, 2025
Merged

misc: Make event loop THE implementation for httpRemoteTask and related code #26697

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions presto-main-base/src/main/java/com/facebook/presto/execution/TaskManagerConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,6 @@ public class TaskManagerConfig
private double highMemoryTaskKillerGCReclaimMemoryThreshold = 0.01;
private Duration highMemoryTaskKillerFrequentFullGCDurationThreshold = new Duration(1, SECONDS);
private double highMemoryTaskKillerHeapMemoryThreshold = 0.9;
private boolean enableEventLoop = true;
private Duration slowMethodThresholdOnEventLoop = new Duration(0, SECONDS);

public long getSlowMethodThresholdOnEventLoop()
Expand All @@ -114,18 +113,6 @@ public TaskManagerConfig setSlowMethodThresholdOnEventLoop(Duration slowMethodTh
return this;
}

@Config("task.enable-event-loop")
public TaskManagerConfig setEventLoopEnabled(boolean enableEventLoop)
{
this.enableEventLoop = enableEventLoop;
return this;
}

public boolean isEventLoopEnabled()
{
return enableEventLoop;
}

@MinDuration("1ms")
@MaxDuration("10s")
@NotNull
Expand Down
5 changes: 1 addition & 4 deletions presto-main-base/src/test/java/com/facebook/presto/execution/TestTaskManagerConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,8 +80,7 @@ public void testDefaults()
.setHighMemoryTaskKillerFrequentFullGCDurationThreshold(new Duration(1, SECONDS))
.setHighMemoryTaskKillerHeapMemoryThreshold(0.9)
.setTaskUpdateSizeTrackingEnabled(true)
.setSlowMethodThresholdOnEventLoop(new Duration(0, SECONDS))
.setEventLoopEnabled(true));
.setSlowMethodThresholdOnEventLoop(new Duration(0, SECONDS)));
}

@Test
Expand Down Expand Up @@ -130,7 +129,6 @@ public void testExplicitPropertyMappings()
.put("experimental.task.high-memory-task-killer-frequent-full-gc-duration-threshold", "2s")
.put("experimental.task.high-memory-task-killer-heap-memory-threshold", "0.8")
.put("task.update-size-tracking-enabled", "false")
.put("task.enable-event-loop", "false")
.put("task.event-loop-slow-method-threshold", "10m")
.build();

Expand Down Expand Up @@ -177,7 +175,6 @@ public void testExplicitPropertyMappings()
.setHighMemoryTaskKillerFrequentFullGCDurationThreshold(new Duration(2, SECONDS))
.setHighMemoryTaskKillerHeapMemoryThreshold(0.8)
.setTaskUpdateSizeTrackingEnabled(false)
.setEventLoopEnabled(false)
.setSlowMethodThresholdOnEventLoop(new Duration(10, MINUTES));

assertFullMapping(properties, expected);
Expand Down
312 changes: 0 additions & 312 deletions ...main/src/main/java/com/facebook/presto/server/remotetask/ContinuousTaskStatusFetcher.java
View file
Open in desktop

This file was deleted.

Loading
Loading