Commit c526fa0
authored
misc: Make event loop THE implementation for httpRemoteTask and related code (#26697)
## Description
1. event loop based http remote task, task status fetcher and task info
fetcher has been reliably running in production for many months now.
This pr makes event loop as the default implementation for those three
classes and remove the old code.
2. I also tried to replay production queries with only 5 threads for the
event loop attempting to catch any potential issues but no issue has
been found.
3. heapdump analysis also showed that the failTask call is heavy
containing a recursive toFailure call. This is something we can
optimize.
## Motivation and Context
clean up the duplicate code back then for roll out purpose.
## Impact
<!---Describe any public API or user-facing feature change or any
performance impact-->
## Test Plan
1. passed verifiers
## Contributor checklist
- [ ] Please make sure your submission complies with our [contributing
guide](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md),
in particular [code
style](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#code-style)
and [commit
standards](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#commit-standards).
- [ ] PR description addresses the issue accurately and concisely. If
the change is non-trivial, a GitHub Issue is referenced.
- [ ] Documented new properties (with its default value), SQL syntax,
functions, or other functionality.
- [ ] If release notes are required, they follow the [release notes
guidelines](https://github.com/prestodb/presto/wiki/Release-Notes-Guidelines).
- [ ] Adequate tests were added if applicable.
- [ ] CI passed.
- [ ] If adding new dependencies, verified they have an [OpenSSF
Scorecard](https://securityscorecards.dev/#the-checks) score of 5.0 or
higher (or obtained explicit TSC approval for lower scores).
## Release Notes
```
== NO RELEASE NOTE ==
```1 parent 0741995 commit c526fa0
File tree
9 files changed
+33
-2774
lines changed- presto-main-base/src
- main/java/com/facebook/presto/execution
- test/java/com/facebook/presto/execution
- presto-main/src
- main/java/com/facebook/presto/server/remotetask
- test/java/com/facebook/presto/server/remotetask
9 files changed
+33
-2774
lines changedLines changed: 0 additions & 13 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
99 | 99 | | |
100 | 100 | | |
101 | 101 | | |
102 | | - | |
103 | 102 | | |
104 | 103 | | |
105 | 104 | | |
| |||
114 | 113 | | |
115 | 114 | | |
116 | 115 | | |
117 | | - | |
118 | | - | |
119 | | - | |
120 | | - | |
121 | | - | |
122 | | - | |
123 | | - | |
124 | | - | |
125 | | - | |
126 | | - | |
127 | | - | |
128 | | - | |
129 | 116 | | |
130 | 117 | | |
131 | 118 | | |
| |||
Lines changed: 1 addition & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
80 | 80 | | |
81 | 81 | | |
82 | 82 | | |
83 | | - | |
84 | | - | |
| 83 | + | |
85 | 84 | | |
86 | 85 | | |
87 | 86 | | |
| |||
130 | 129 | | |
131 | 130 | | |
132 | 131 | | |
133 | | - | |
134 | 132 | | |
135 | 133 | | |
136 | 134 | | |
| |||
177 | 175 | | |
178 | 176 | | |
179 | 177 | | |
180 | | - | |
181 | 178 | | |
182 | 179 | | |
183 | 180 | | |
| |||
Lines changed: 0 additions & 312 deletions
This file was deleted.
0 commit comments