Skip to content

Commit f45654c

Browse files
authored
chore: Rename dataset creation buttons (apache#34544)
1 parent 761daec commit f45654c

File tree

2 files changed

+13
-13
lines changed

2 files changed

+13
-13
lines changed

superset-frontend/src/features/datasets/AddDataset/Footer/Footer.test.tsx

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ describe('Footer', () => {
7272
});
7373

7474
const createButton = screen.getByRole('button', {
75-
name: /Create dataset and create chart/i,
75+
name: /Create and explore dataset/i,
7676
});
7777

7878
expect(saveButton).toBeVisible();
@@ -83,13 +83,13 @@ describe('Footer', () => {
8383
render(<Footer {...mockPropsWithDataset} />, { useRedux: true });
8484

8585
const createButton = screen.getByRole('button', {
86-
name: /Create dataset and create chart/i,
86+
name: /Create and explore dataset/i,
8787
});
8888

8989
expect(createButton).toBeEnabled();
9090

9191
// Check that it's a dropdown button with the correct text
92-
expect(createButton).toHaveTextContent('Create dataset and create chart');
92+
expect(createButton).toHaveTextContent('Create and explore dataset');
9393

9494
// Check for the dropdown arrow
9595
const dropdownArrow = screen.getByRole('img', { hidden: true });
@@ -102,7 +102,7 @@ describe('Footer', () => {
102102
});
103103

104104
const createButton = screen.getByRole('button', {
105-
name: /Create dataset and create chart/i,
105+
name: /Create and explore dataset/i,
106106
});
107107

108108
expect(createButton).toBeDisabled();
@@ -117,7 +117,7 @@ describe('Footer', () => {
117117

118118
// Check that the dropdown menu option is visible
119119
await waitFor(() => {
120-
expect(screen.getByText('Create dataset only')).toBeVisible();
120+
expect(screen.getByText('Create dataset')).toBeVisible();
121121
});
122122
});
123123

@@ -127,7 +127,7 @@ describe('Footer', () => {
127127
render(<Footer {...mockPropsWithDataset} />, { useRedux: true });
128128

129129
const createButton = screen.getByRole('button', {
130-
name: /Create dataset and create chart/i,
130+
name: /Create and explore dataset/i,
131131
});
132132

133133
userEvent.click(createButton);
@@ -145,7 +145,7 @@ describe('Footer', () => {
145145
});
146146
});
147147

148-
test('navigates to dataset list when "Create dataset only" menu option is clicked', async () => {
148+
test('navigates to dataset list when "Create dataset" menu option is clicked', async () => {
149149
mockCreateResource.mockResolvedValue(123);
150150

151151
render(<Footer {...mockPropsWithDataset} />, { useRedux: true });
@@ -154,9 +154,9 @@ describe('Footer', () => {
154154
const dropdownTrigger = screen.getByRole('button', { name: 'down' });
155155
userEvent.click(dropdownTrigger);
156156

157-
// Click the "Create dataset only" option
157+
// Click the "Create dataset" option
158158
await waitFor(() => {
159-
const datasetOnlyOption = screen.getByText('Create dataset only');
159+
const datasetOnlyOption = screen.getByText('Create dataset');
160160
userEvent.click(datasetOnlyOption);
161161
});
162162

@@ -177,7 +177,7 @@ describe('Footer', () => {
177177
render(<Footer {...mockPropsWithDataset} />, { useRedux: true });
178178

179179
const createButton = screen.getByRole('button', {
180-
name: /Create dataset and create chart/i,
180+
name: /Create and explore dataset/i,
181181
});
182182

183183
userEvent.click(createButton);
@@ -203,7 +203,7 @@ describe('Footer', () => {
203203
render(<Footer {...mockPropsWithCatalog} />, { useRedux: true });
204204

205205
const createButton = screen.getByRole('button', {
206-
name: /Create dataset and create chart/i,
206+
name: /Create and explore dataset/i,
207207
});
208208

209209
userEvent.click(createButton);

superset-frontend/src/features/datasets/AddDataset/Footer/index.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -121,8 +121,8 @@ function Footer({
121121
onSave(false);
122122
};
123123

124-
const CREATE_DATASET_TEXT = t('Create dataset and create chart');
125-
const CREATE_DATASET_ONLY_TEXT = t('Create dataset only');
124+
const CREATE_DATASET_TEXT = t('Create and explore dataset');
125+
const CREATE_DATASET_ONLY_TEXT = t('Create dataset');
126126
const disabledCheck =
127127
!datasetObject?.table_name ||
128128
!hasColumns ||

0 commit comments

Comments
 (0)