From 51e090d67a914bf6692d8256de2d232dd7882666 Mon Sep 17 00:00:00 2001 From: mcdogg17 <63260972+mcdogg17@users.noreply.github.com> Date: Fri, 24 Jan 2025 04:14:12 +0500 Subject: [PATCH] fix(verbose map): Correct raw metrics handling in verbose map (#29417) --- superset/connectors/sqla/models.py | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/superset/connectors/sqla/models.py b/superset/connectors/sqla/models.py index 2acc7b12b6647..7d0570b92b81d 100644 --- a/superset/connectors/sqla/models.py +++ b/superset/connectors/sqla/models.py @@ -359,12 +359,15 @@ def order_by_choices(self) -> list[tuple[str, str]]: @property def verbose_map(self) -> dict[str, str]: verb_map = {"__timestamp": "Time"} - verb_map.update( - {o.metric_name: o.verbose_name or o.metric_name for o in self.metrics} - ) - verb_map.update( - {o.column_name: o.verbose_name or o.column_name for o in self.columns} - ) + + for o in self.metrics: + if o.metric_name not in verb_map: + verb_map[o.metric_name] = o.verbose_name or o.metric_name + + for o in self.columns: + if o.column_name not in verb_map: + verb_map[o.column_name] = o.verbose_name or o.column_name + return verb_map @property