Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TrieNode String #6

Open
lpalbou opened this issue Jul 24, 2018 · 0 comments
Open

TrieNode String #6

lpalbou opened this issue Jul 24, 2018 · 0 comments

Comments

@lpalbou
Copy link

lpalbou commented Jul 24, 2018

curie-util/src/main/java/org/prefixcommons/trie/Trie.java

Line 69 in 2911bed

result += ch; // Update result

Should not use += when called multiple times and aiming at efficiency. Every concatenation done this way instantiate a new String (old value + new value).
julesjacobsen added a commit to julesjacobsen/curie-util that referenced this issue Apr 3, 2019
@julesjacobsen
Use StringBuilder for concatenating strings in Trie - Issue prefixcom…
b9aa33d 
…mons#6

Remove superfluous comments
@julesjacobsen julesjacobsen mentioned this issue Apr 3, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lpalbou