build windows servercore image #58
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelzw
reviewed
Nov 30, 2024
| @@ -162,4 +227,4 @@ jobs: | |||
| uses: softprops/action-gh-release@v2 | |||
| with: | |||
| generate_release_notes: true | |||
| tag_name: ${{ needs.version.outputs.new-version }} | |||
| tag_name: ${{ needs.version.outputs.new-version }} | |||
There was a problem hiding this comment.
Suggested change
| tag_name: ${{ needs.version.outputs.new-version }} | |
| tag_name: ${{ needs.version.outputs.new-version }} | |
| RUN Invoke-WebRequest -Uri "https://github.com/prefix-dev/pixi/releases/download/v${env:PIXI_VERSION}/pixi-x86_64-pc-windows-msvc.exe" -OutFile C:\Windows\System32\pixi.exe | ||
|
|
||
| RUN pixi --version | ||
|
|
pavelzw
reviewed
Dec 3, 2024
| RUN mkdir C:\Pixi | ||
|
|
||
| # Download Pixi | ||
| ADD https://github.com/prefix-dev/pixi/releases/download/v${PIXI_VERSION}/pixi-x86_64-pc-windows-msvc.exe C:\Pixi\pixi.exe |
There was a problem hiding this comment.
while we're at it: there is also https://github.com/prefix-dev/pixi/releases/download/v0.39.0/pixi-aarch64-pc-windows-msvc.exe. wdyt of doing a multi-arch build on windows as well similar to linux?
| shell: pwsh | ||
|
|
||
| - name: Login to GHCR | ||
| uses: docker/login-action@9780b0c442fbb1117ed29e0efdff1e18412f7567 |
There was a problem hiding this comment.
Suggested change
| uses: docker/login-action@9780b0c442fbb1117ed29e0efdff1e18412f7567 | |
| uses: docker/login-action@9780b0c442fbb1117ed29e0efdff1e18412f7567 # v3.3.0 |
| ADD https://github.com/prefix-dev/pixi/releases/download/v${PIXI_VERSION}/pixi-x86_64-pc-windows-msvc.exe C:\Pixi\pixi.exe | ||
|
|
||
| # Set PATH environment variable | ||
| ENV PATH="C:\Pixi;${PATH}" |
There was a problem hiding this comment.
Suggested change
| ENV PATH="C:\Pixi;${PATH}" | |
| ENV PATH="C:\Pixi;${PATH}" | |
dhirschfeld
reviewed
Feb 11, 2025
Comment on lines
+1
to
+12
| # escape=` | ||
|
|
||
| ARG BASE_IMAGE | ||
| FROM ${BASE_IMAGE} | ||
|
|
||
| ARG PIXI_VERSION | ||
|
|
||
| # Create a directory for Pixi | ||
| RUN mkdir C:\Pixi | ||
|
|
||
| # Download Pixi | ||
| ADD https://github.com/prefix-dev/pixi/releases/download/v${PIXI_VERSION}/pixi-x86_64-pc-windows-msvc.exe C:\Pixi\pixi.exe |
There was a problem hiding this comment.
I always enable long paths as a matter of course. You might also be able to save a layer by using a heredoc:
Suggested change
| # escape=` | |
| ARG BASE_IMAGE | |
| FROM ${BASE_IMAGE} | |
| ARG PIXI_VERSION | |
| # Create a directory for Pixi | |
| RUN mkdir C:\Pixi | |
| # Download Pixi | |
| ADD https://github.com/prefix-dev/pixi/releases/download/v${PIXI_VERSION}/pixi-x86_64-pc-windows-msvc.exe C:\Pixi\pixi.exe | |
| # syntax=docker/dockerfile:1 | |
| # escape=` | |
| ARG BASE_IMAGE | |
| FROM ${BASE_IMAGE} | |
| ARG PIXI_VERSION | |
| # Create a directory for Pixi | |
| RUN <<EOF | |
| mkdir C:\Pixi | |
| curl.exe -fsSL "https://github.com/prefix-dev/pixi/releases/download/v${PIXI_VERSION}/pixi-x86_64-pc-windows-msvc.exe" -o C:\Pixi\pixi.exe | |
| if ($LASTEXITCODE -ne 0) { | |
| exit $LASTEXITCODE | |
| } | |
| Set-ItemProperty -Path HKLM:\SYSTEM\CurrentControlSet\Control\FileSystem -Name LongPathsEnabled -Value 1 | |
| EOF |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
built on my fork here: https://github.com/jamesfricker/pixi-docker/actions/runs/12095385879/job/33728500880
based on base image: https://hub.docker.com/r/microsoft/windows-servercore
closes #36