Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider exposing one-shot receiver from ByteWriter write function #317

Open
wxing1292 opened this issue Sep 21, 2021 · 0 comments
Open
Labels
enhancement New feature or request Priority Should be prioritized

Comments

@wxing1292
Copy link
Contributor

Problem description

pub async fn write(&mut self, buf: &[u8]) -> Result<usize, Error>

does not expose the inner one shot channel, caller can potentially benefit from async notification if the one-shot channel is exposed (instead of calling the flush method, which takes &mut self)

Problem location
link

Suggestions for an improvement
Expose the one shot receiver (perhaps change to broadcast receiver?)

@Tristan1900 Tristan1900 added Priority Should be prioritized enhancement New feature or request labels Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Priority Should be prioritized
Projects
None yet
Development

No branches or pull requests

2 participants