Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Edit button overflows container for extra wide images #995

Open
2 tasks done
BSoDium opened this issue Aug 15, 2024 · 3 comments
Open
2 tasks done

[Bug] Edit button overflows container for extra wide images #995

BSoDium opened this issue Aug 15, 2024 · 3 comments
Labels

Comments

@BSoDium
Copy link

BSoDium commented Aug 15, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Have you updated FilePond and its plugins?

  • I have updated FilePond and its plugins

Describe the bug

The edit button overflows the image container when the image is very wide and not high enough displaying on top of the "Upload completed" message. An easy fix could involve displaying that button inline next to the deletion one for exotic sizes such as this one, or setting a minimum height for the container.

Reproduction

Go to https://pqina.nl/filepond/#examples and upload a very wide image (tested with 2616 × 372px), the result can be seen below:

CleanShot 2024-08-15 at 11 02 36@2x

Environment

- Device: Macbook Air M1
- OS: MacOS Sonoma 14.6.1 (23G93)
- Browser: Chrome version 127.0.6533.100 (Official Build) (arm64)
@BSoDium BSoDium added the bug label Aug 15, 2024
@rikschennink
Copy link
Collaborator

You could set a fixed styleItemPanelAspectRatio that will center the image in a box of the given aspect ratio.

@BSoDium
Copy link
Author

BSoDium commented Aug 15, 2024

Totally agree! This is easily fixable, but I think it could be cool if the bug didn't happen in the first place.

@rikschennink
Copy link
Collaborator

@BSoDium certainly something I'm looking into for v5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants