Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move and clean up Silence #12441

Open
wants to merge 20 commits into
base: master
Choose a base branch
from
Open

Move and clean up Silence #12441

wants to merge 20 commits into from

Conversation

Userlog2
Copy link
Contributor

@Userlog2 Userlog2 commented Nov 14, 2024

Should be ready for merge now, waiting on final review

  • Changed Silence article to add details regarding silence lengths this will come in a different PR, after an internal discussion within the GMT.
  • Changed "42-hour silences" to 43 hours in the Rules, Song Content Rules, and Visual Content Considerations
  • Added details about what happens to inappropriate visual content to the Visual Content Considerations page
  • Moved Silence article to Help_centre, where Account_restrictions lives
  • Removed the phrase "timed out" from the rules

Note: I speak relatively fluent Danish; I will therefore be correcting mistakes if I see any. A full update of that page will come later in a different PR.

To do

  • Outdate translations
  • (optional) Give the German version a localized screenshot
  • Put the PR number in redirect.yaml
  • Await GMT discussion of what should be added

Self-check

Need to get a new screenshot for the German version, and ask for a review of the wording and factual accuracy.
"Timed out" is not a term in osu!.
Long silence lengths are now universally 43 hours, not 42 or (on older translations) 48 - except for the Russian version.

Some versions had the phrase "timed out" removed since it's not a phrase in osu!. Not all, however.

The Danish translation was partially fixed as well (it used to say users *themselves* could be removed after 3 months of a restriction instead of the restriction being removed).
@Userlog2 Userlog2 requested a review from peppy as a code owner November 14, 2024 17:32
Copy link

Someone else has edited same files as you did. Please check their changes in case they conflict with yours:

@Userlog2 Userlog2 changed the title Silence rework Add details to Silence regarding lengths Nov 14, 2024
@0x84f
Copy link
Contributor

0x84f commented Nov 14, 2024

i notified the GMT of the osu!wiki thread, we should take this opportunity to discuss some wiki enhancements and add it either via this PR or a separate one

@pull-request-size pull-request-size bot added size/L and removed size/M labels Nov 14, 2024
Added a section about what happens for inappropriate visual content and related penalties to the VCC page, like the Song Content Rules page has.
wiki/Help_centre/Silence/de.md Outdated Show resolved Hide resolved
wiki/Help_centre/Silence/de.md Outdated Show resolved Hide resolved
Copy link
Member

@cl8n cl8n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the 42->43 stuff is ok but pls dont make wording changes in translations in a PR like this, it makes review difficult

e: can keep DE changes since someone already reviewed.

wiki/Help_centre/Silence/en.md Outdated Show resolved Hide resolved
wiki/Help_centre/Silence/en.md Outdated Show resolved Hide resolved
wiki/Help_centre/Silence/en.md Outdated Show resolved Hide resolved
wiki/Help_centre/Silence/en.md Outdated Show resolved Hide resolved
wiki/Help_centre/Silence/en.md Outdated Show resolved Hide resolved
Userlog2 and others added 2 commits November 16, 2024 13:40
Co-authored-by: clayton <[email protected]>
French translation of `Rules` reverted.
Since I am a native Danish speaker, those changes should be fine.
@Userlog2
Copy link
Contributor Author

@cl8n reverted French translation change, Danish should (?) be fine since I'm a native speaker

wiki/redirect.yaml Outdated Show resolved Hide resolved
wiki/Help_centre/Silence/en.md Outdated Show resolved Hide resolved
@Userlog2 Userlog2 requested a review from cl8n November 18, 2024 13:08
peppy
peppy previously approved these changes Nov 18, 2024
Copy link
Member

@peppy peppy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"43 hours" is weird but sure

Copy link
Contributor

@0x84f 0x84f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the GMT have concluded that we as a team need to further discuss what additions we want to make, therefore for now silence lengths or specific reasons should not be a part of this PR

the GMT & wiki maintainers will be handling any future updates to this page if we conclude that changes need to be made

wiki/Help_centre/Silence/en.md Outdated Show resolved Hide resolved
wiki/Help_centre/Silence/en.md Outdated Show resolved Hide resolved
wiki/Help_centre/Silence/en.md Outdated Show resolved Hide resolved
@cl8n
Copy link
Member

cl8n commented Nov 20, 2024

the GMT & wiki maintainers will be handling any future updates

I wish we would be doing less of this going forward, and not more. community wikis are more useful when they freely document anything that could be relevant to readers

@peppy
Copy link
Member

peppy commented Nov 20, 2024

Yeah I don't get what the above messaging even means.

But also I'm a bit against having "specific durations for specific offences" since that's not how the system historically worked.

@0x84f
Copy link
Contributor

0x84f commented Nov 20, 2024

i didnt express myself properly when i said "the gmt/wiki maintainers will handle updates going forward", my point was that these changes cannot just be added without consulting the team first, hence why I notified everyone of the proposed changes. also meant to say that I will open a PR when the team decides what to update, so this doesn't stay open for an extended period of time

after a discussion and a vote we didn't get crystal clear results of what the team wants (after all, its 60+ people with different opinions), but the majority agreed that what was added by userlog2 should not be there until we cleared up internally what we want

the team wants some stuff to be updated, we are just not sure what yet, and need some extra time to iron the details out

internal discussion, voting results

@Userlog2 Userlog2 changed the title Add details to Silence regarding lengths Move and clean up Silence Nov 20, 2024
matches related articles (Account_restrictions, Tournament_bans)
Copy link

Someone else has edited same files as you did. Please check their changes in case they conflict with yours:

Walavouchey
Walavouchey previously approved these changes Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants