Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a special lazer wiki for all lazer mods #12105

Draft
wants to merge 231 commits into
base: master
Choose a base branch
from
Draft

Conversation

Anax2i
Copy link

@Anax2i Anax2i commented Sep 6, 2024

Copy link

github-actions bot commented Sep 6, 2024

Thank you for contributing to the osu! wiki.

Please take note of the following:

  • Make sure you've read this self-check checklist.

  • Translations that have not been reviewed by a native speaker will be merged after a minimum of 1 week. If there are no reviewers for your language, please mention it explicitly.

  • Refrain from spamming the Update branch button. A maintainer will do this before merging anyway.

  • Apply review suggestions in batches from the Files changed tab like this:

    Demo GIF

See the contribution guide for more information.

All changes are run through continuous integration checks, which provide automatic detection of common errors. If you need help with decrypting CI check error messages, or with any other issues, ask in the #osu-wiki channel on the osu! Discord server.

Copy link
Member

@Hiviexd Hiviexd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

things i noticed on a first glance:

  • should replace lazer with osu!(lazer) whenever possible
  • would be better to put mod icon images in infoboxes rather than inline
  • should probably point out the settings of each mod in a header and explain each of them a bit

@cl8n cl8n self-requested a review September 6, 2024 23:42
wiki/Gameplay/Game_modifier/Lazer/Classic/en.md Outdated Show resolved Hide resolved
wiki/Gameplay/Game_modifier/Easy/en.md Outdated Show resolved Hide resolved
wiki/Gameplay/Game_modifier/Lazer/Classic/en.md Outdated Show resolved Hide resolved
wiki/Gameplay/Game_modifier/Lazer/Easy/en.md Outdated Show resolved Hide resolved
wiki/Gameplay/Game_modifier/Lazer/Floating_Fruits/en.md Outdated Show resolved Hide resolved
wiki/Gameplay/Game_modifier/Lazer/No_Scope/en.md Outdated Show resolved Hide resolved
wiki/Gameplay/Game_modifier/en.md Outdated Show resolved Hide resolved
wiki/Gameplay/Game_modifier/Lazer/Classic/en.md Outdated Show resolved Hide resolved
wiki/Gameplay/Game_modifier/Lazer/Easy/en.md Outdated Show resolved Hide resolved
wiki/Gameplay/Game_modifier/Lazer/en.md Outdated Show resolved Hide resolved
@cl8n
Copy link
Member

cl8n commented Sep 7, 2024

  • should replace lazer with osu!(lazer) whenever possible

I think this isn't great writing advice, there is a place for osu!(lazer) when you need to clarify the version you're talking about, but if you are specifically comparing against stable then just "lazer" reads a lot better. this article has examples of both ways to write it that are used well imo

@Anax2i Anax2i changed the title Create a special lazer wiki for all lazer mods (preview) Create a special lazer wiki for all lazer mods Dec 11, 2024
@Anax2i
Copy link
Author

Anax2i commented Dec 11, 2024

Does it look good enough like this? @cl8n

@cl8n
Copy link
Member

cl8n commented Dec 11, 2024

I thought the idea was to work out the final version of the mods that were already in the PR at the point of my last review, and only later add more mods 😅 I guess we can just do the whole thing in one go but this is going to take me a long time to get thru...

@Anax2i
Copy link
Author

Anax2i commented Dec 12, 2024

I thought the idea was to work out the final version of the mods that were already in the PR at the point of my last review, and only later add more mods 😅 I guess we can just do the whole thing in one go but this is going to take me a long time to get thru...

I'm so sorry, I was too impatient about it 😭 but I hope it won't be too much; I'll be there to make each mod page as complete as possible by adding all the necessary information, so that it's done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XXL state/needs rebase before merging, a maintainer will rebase to fix commit messages, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants