Adding references, clarifying dates, and adding missing details regarding the MAT #11705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks to OnosakiHito for helping me find the forum posts
iSlodinxOsu
suggested changes
Jul 8, 2024
cl8n
requested changes
Aug 11, 2024
Comment on lines
27
to
32
| [^1]: [Forum post announcing the creation of the MAT.](https://osu.ppy.sh/community/forums/topics/21856?n=1) | ||
| [^2]: [Forum post announcing the addition of the new members.](https://osu.ppy.sh/community/forums/topics/25314?n=1) | ||
| [^4]: [Forum post announcing the end of the MAT.](https://osu.ppy.sh/community/forums/topics/129165?n=1) | ||
| [^3]: [(Restricted) Forum post announcing the discontinuation of proto-bubbles for MATs.](https://osu.ppy.sh/community/forums/topics/28143?n=57) | ||
| [^4]: [(Restricted) Forum post discussing the state of the MAT.](https://osu.ppy.sh/community/forums/topics/36277?n=1) | ||
| [^5]: [Forum post announcing that MATs are able to bubble maps.](https://osu.ppy.sh/community/forums/topics/38405?n=1) |
There was a problem hiding this comment.
a few things here:
- as CI says already, you have some duplicate definition IDs here, looks like a mistake
- it would probably be better to give these definitions names instead of just numbering them
- when linking to a specific post, use the link of form
https://osu.ppy.sh/community/forums/posts/{post} - no need to say "(Restricted)" (also one of them is public anyway)
There was a problem hiding this comment.
I fixed the duplicate IDs and removed "(Restricted)", but trying to change the format of the link broke them and they sent me to completely unrelated posts. Also, I think the definitions being numbered are fine, they're just there to cite the source, nothing fancy is need.
Co-authored-by: clayton <[email protected]> Co-authored-by: iSlodinx <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to OnosakiHito for helping me find the forum posts.
Self-check