Additional Strict Concurrency Declarations (#75)

* added more sendable annotations. Update example app to use Swift 6 Strict concurrency checking

* Add changelog entry

* update sync status sendable status. Update logger usage in tests.

Author: stevensJourney

CHANGELOG.md

@@ -3,6 +3,7 @@
 ## 1.5.1 (unreleased)
 
 * Update core extension to 0.4.5 ([changelog](https://github.com/powersync-ja/powersync-sqlite-core/releases/tag/v0.4.5))
+* Additional Swift 6 Strict Concurrency Checking declarations added for remaining protocols.
 
 ## 1.5.0
 

Demo/PowerSyncExample.xcodeproj/project.pbxproj

@@ -645,6 +645,7 @@
 				SDKROOT = iphoneos;
 				SWIFT_ACTIVE_COMPILATION_CONDITIONS = "DEBUG $(inherited)";
 				SWIFT_OPTIMIZATION_LEVEL = "-Onone";
+				SWIFT_STRICT_CONCURRENCY = complete;
 			};
 			name = Debug;
 		};
@@ -701,6 +702,7 @@
 				OTHER_LDFLAGS = "-lsqlite3";
 				SDKROOT = iphoneos;
 				SWIFT_COMPILATION_MODE = wholemodule;
+				SWIFT_STRICT_CONCURRENCY = complete;
 				VALIDATE_PRODUCT = YES;
 			};
 			name = Release;
@@ -742,7 +744,7 @@
 				SWIFT_OBJC_BRIDGING_HEADER = "PowerSyncExample/PowerSyncExample-Bridging-Header.h";
 				"SWIFT_OBJC_BRIDGING_HEADER[arch=*]" = "";
 				SWIFT_OPTIMIZATION_LEVEL = "-Onone";
-				SWIFT_VERSION = 5.0;
+				SWIFT_VERSION = 6.0;
 				TARGETED_DEVICE_FAMILY = "1,2";
 			};
 			name = Debug;
@@ -781,7 +783,7 @@
 				SUPPORTS_MAC_DESIGNED_FOR_IPHONE_IPAD = NO;
 				SWIFT_EMIT_LOC_STRINGS = YES;
 				SWIFT_OBJC_BRIDGING_HEADER = "PowerSyncExample/PowerSyncExample-Bridging-Header.h";
-				SWIFT_VERSION = 5.0;
+				SWIFT_VERSION = 6.0;
 				TARGETED_DEVICE_FAMILY = "1,2";
 			};
 			name = Release;

Demo/PowerSyncExample/Components/AddListView.swift

@@ -13,9 +13,9 @@ struct AddListView: View {
                 Task {
                     do {
                         try await system.insertList(newList)
-                        await completion(.success(true))
+                        completion(.success(true))
                     } catch {
-                        await completion(.failure(error))
+                        completion(.failure(error))
                         throw error
                     }
                 }

Demo/PowerSyncExample/Components/AddTodoListView.swift

@@ -15,9 +15,9 @@ struct AddTodoListView: View {
                 Task{
                     do {
                         try await system.insertTodo(newTodo, listId)
-                        await completion(.success(true))
+                        completion(.success(true))
                     } catch {
-                        await completion(.failure(error))
+                        completion(.failure(error))
                         throw error
                     }
                 }

Demo/PowerSyncExample/PowerSync/SupabaseConnector.swift

@@ -38,13 +38,14 @@ private enum PostgresFatalCodes {
 }
 
 @Observable
+@MainActor // _session is mutable, limiting to the MainActor satisfies Sendable constraints
 final class SupabaseConnector: PowerSyncBackendConnectorProtocol {
     let powerSyncEndpoint: String = Secrets.powerSyncEndpoint
     let client: SupabaseClient = .init(
         supabaseURL: Secrets.supabaseURL,
         supabaseKey: Secrets.supabaseAnonKey,
     )
-    var session: Session?
+    private(set) var session: Session?
     private var errorCode: String?
 
     @ObservationIgnored

Demo/PowerSyncExample/PowerSync/SupabaseRemoteStorage.swift

@@ -2,7 +2,7 @@ import Foundation
 import PowerSync
 import Supabase
 
-class SupabaseRemoteStorage: RemoteStorageAdapter {
+final class SupabaseRemoteStorage: RemoteStorageAdapter {
     let storage: Supabase.StorageFileApi
 
     init(storage: Supabase.StorageFileApi) {

Demo/PowerSyncExample/PowerSync/SystemManager.swift

@@ -13,13 +13,16 @@ func getAttachmentsDirectoryPath() throws -> String {
 
 let logTag = "SystemManager"
 
+/// We use the MainActor SupabaseConnector synchronously here, this requires specifying that SystemManager runs on the MainActor
+/// We don't actually block the MainActor with anything
 @Observable
-class SystemManager {
+@MainActor
+final class SystemManager {
     let connector = SupabaseConnector()
     let schema = AppSchema
     let db: PowerSyncDatabaseProtocol
 
-    var attachments: AttachmentQueue?
+    let attachments: AttachmentQueue?
 
     init() {
         db = PowerSyncDatabase(
@@ -226,25 +229,18 @@ class SystemManager {
             try await attachments.deleteFile(
                 attachmentId: photoId
             ) { transaction, _ in
-                try self.deleteTodoInTX(
-                    id: todo.id,
-                    tx: transaction
+                try transaction.execute(
+                    sql: "DELETE FROM \(TODOS_TABLE) WHERE id = ?",
+                    parameters: [todo.id]
                 )
             }
         } else {
-            try await db.writeTransaction { transaction in
-                try self.deleteTodoInTX(
-                    id: todo.id,
-                    tx: transaction
+            _ = try await db.writeTransaction { transaction in
+                try transaction.execute(
+                    sql: "DELETE FROM \(TODOS_TABLE) WHERE id = ?",
+                    parameters: [todo.id]
                 )
             }
         }
     }
-
-    private func deleteTodoInTX(id: String, tx: ConnectionContext) throws {
-        _ = try tx.execute(
-            sql: "DELETE FROM \(TODOS_TABLE) WHERE id = ?",
-            parameters: [id]
-        )
-    }
 }

Sources/PowerSync/Kotlin/KotlinTypes.swift

@@ -8,3 +8,7 @@ extension KotlinPowerSyncBackendConnector: @retroactive @unchecked Sendable {}
 extension KotlinPowerSyncCredentials: @retroactive @unchecked Sendable {}
 extension PowerSyncKotlin.KermitLogger: @retroactive @unchecked Sendable {}
 extension PowerSyncKotlin.SyncStatus: @retroactive @unchecked Sendable {}
+
+extension PowerSyncKotlin.CrudEntry: @retroactive @unchecked Sendable {}
+extension PowerSyncKotlin.CrudBatch: @retroactive @unchecked Sendable {}
+extension PowerSyncKotlin.CrudTransaction: @retroactive @unchecked Sendable {}

Sources/PowerSync/Kotlin/sync/KotlinSyncStatusData.swift

@@ -103,11 +103,17 @@ extension KotlinProgressWithOperationsProtocol {
     }
 }
 
-struct KotlinProgressWithOperations: KotlinProgressWithOperationsProtocol {
+struct KotlinProgressWithOperations: KotlinProgressWithOperationsProtocol,
+    // We can't mark  PowerSyncKotlin.ProgressWithOperations as Sendable
+    @unchecked Sendable
+{
     let base: PowerSyncKotlin.ProgressWithOperations
 }
 
-struct KotlinSyncDownloadProgress: KotlinProgressWithOperationsProtocol, SyncDownloadProgress {
+struct KotlinSyncDownloadProgress: KotlinProgressWithOperationsProtocol, SyncDownloadProgress,
+    // We can't mark  PowerSyncKotlin.SyncDownloadProgress as Sendable
+    @unchecked Sendable
+{
     let progress: PowerSyncKotlin.SyncDownloadProgress
 
     var base: any PowerSyncKotlin.ProgressWithOperations {

Sources/PowerSync/Logger.swift

@@ -3,15 +3,10 @@ import OSLog
 /// A log writer which prints to the standard output
 ///
 /// This writer uses `os.Logger` on iOS/macOS/tvOS/watchOS 14+ and falls back to `print` for earlier versions.
-public class PrintLogWriter: LogWriterProtocol {
+public final class PrintLogWriter: LogWriterProtocol {
     private let subsystem: String
     private let category: String
-    private lazy var logger: Any? = {
-        if #available(iOS 14.0, macOS 11.0, tvOS 14.0, watchOS 7.0, *) {
-            return Logger(subsystem: subsystem, category: category)
-        }
-        return nil
-    }()
+    private let logger: Sendable?
 
     /// Creates a new PrintLogWriter
     /// - Parameters:
@@ -22,6 +17,12 @@ public class PrintLogWriter: LogWriterProtocol {
     {
         self.subsystem = subsystem
         self.category = category
+
+        if #available(iOS 14.0, macOS 11.0, tvOS 14.0, watchOS 7.0, *) {
+            logger = Logger(subsystem: subsystem, category: category)
+        } else {
+            logger = nil
+        }
     }
 
     /// Logs a message with a given severity and optional tag.