From 1e24e9753ef5d0dcd45b7046a7742f0e4632ed0a Mon Sep 17 00:00:00 2001 From: Ralf Kistner Date: Tue, 25 Mar 2025 17:57:51 +0200 Subject: [PATCH 1/2] Updated expected triggers. --- dart/test/utils/migration_fixtures.dart | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/dart/test/utils/migration_fixtures.dart b/dart/test/utils/migration_fixtures.dart index a76be78..300c16b 100644 --- a/dart/test/utils/migration_fixtures.dart +++ b/dart/test/utils/migration_fixtures.dart @@ -415,6 +415,8 @@ END SELECT CASE WHEN (NEW.id IS NULL) THEN RAISE (FAIL, 'id is required') + WHEN (typeof(NEW.id) != 'text') + THEN RAISE (FAIL, 'id should be text') END; INSERT INTO "ps_data__lists" SELECT NEW.id, json_object('description', NEW."description"); @@ -478,6 +480,8 @@ END SELECT CASE WHEN (NEW.id IS NULL) THEN RAISE (FAIL, 'id is required') + WHEN (typeof(NEW.id) != 'text') + THEN RAISE (FAIL, 'id should be text') END; INSERT INTO "ps_data__lists" SELECT NEW.id, json_object('description', NEW."description"); From 4b779b82c263ff664647cbf6be5ba6651efd3d29 Mon Sep 17 00:00:00 2001 From: Ralf Kistner Date: Tue, 25 Mar 2025 18:03:32 +0200 Subject: [PATCH 2/2] Run tests on pull requests. --- .github/workflows/android.yml | 2 ++ .github/workflows/ios.yml | 2 ++ .github/workflows/linux.yml | 3 +++ .github/workflows/macos.yml | 3 +++ .github/workflows/tests.yml | 2 ++ .github/workflows/valgrind.yml | 1 + .github/workflows/wasm.yml | 2 ++ .github/workflows/windows.yml | 2 ++ 8 files changed, 17 insertions(+) diff --git a/.github/workflows/android.yml b/.github/workflows/android.yml index c32de46..020c466 100644 --- a/.github/workflows/android.yml +++ b/.github/workflows/android.yml @@ -1,9 +1,11 @@ on: push: + pull_request: name: "android" jobs: build: name: Building Android + if: github.event_name == 'push' || (github.event_name == 'pull_request' && github.event.pull_request.head.repo.full_name != github.repository) runs-on: ubuntu-latest steps: - uses: actions/checkout@v3 diff --git a/.github/workflows/ios.yml b/.github/workflows/ios.yml index 49c44c3..aebd68e 100644 --- a/.github/workflows/ios.yml +++ b/.github/workflows/ios.yml @@ -1,9 +1,11 @@ on: push: + pull_request: name: "ios" jobs: build: name: Building iOS + if: github.event_name == 'push' || (github.event_name == 'pull_request' && github.event.pull_request.head.repo.full_name != github.repository) runs-on: macos-latest steps: - uses: actions/checkout@v3 diff --git a/.github/workflows/linux.yml b/.github/workflows/linux.yml index 68b0618..a91d5bf 100644 --- a/.github/workflows/linux.yml +++ b/.github/workflows/linux.yml @@ -1,9 +1,11 @@ on: push: + pull_request: name: "linux" jobs: build_x86_64: name: Building Linux x86_64 + if: github.event_name == 'push' || (github.event_name == 'pull_request' && github.event.pull_request.head.repo.full_name != github.repository) runs-on: ubuntu-latest steps: - uses: actions/checkout@v3 @@ -21,6 +23,7 @@ jobs: build_aarch64: name: Building Linux aarch64 + if: github.event_name == 'push' || (github.event_name == 'pull_request' && github.event.pull_request.head.repo.full_name != github.repository) runs-on: ubuntu-arm64 steps: - uses: actions/checkout@v3 diff --git a/.github/workflows/macos.yml b/.github/workflows/macos.yml index 6460c18..67d24fa 100644 --- a/.github/workflows/macos.yml +++ b/.github/workflows/macos.yml @@ -1,9 +1,11 @@ on: push: + pull_request: name: "macos" jobs: build_macOS_aarch64: name: Building macOS aarch64 + if: github.event_name == 'push' || (github.event_name == 'pull_request' && github.event.pull_request.head.repo.full_name != github.repository) runs-on: macos-latest steps: - uses: actions/checkout@v3 @@ -21,6 +23,7 @@ jobs: build_macOS_x64: name: Building macOS x64 + if: github.event_name == 'push' || (github.event_name == 'pull_request' && github.event.pull_request.head.repo.full_name != github.repository) runs-on: macos-14 steps: - uses: actions/checkout@v3 diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 70e9193..20ec38d 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -1,9 +1,11 @@ on: push: + pull_request: name: "tests" jobs: build: name: Testing on ${{ matrix.os }} + if: github.event_name == 'push' || (github.event_name == 'pull_request' && github.event.pull_request.head.repo.full_name != github.repository) runs-on: ${{ matrix.os }} strategy: fail-fast: false diff --git a/.github/workflows/valgrind.yml b/.github/workflows/valgrind.yml index fefce8e..d780142 100644 --- a/.github/workflows/valgrind.yml +++ b/.github/workflows/valgrind.yml @@ -6,6 +6,7 @@ jobs: build: name: Testing with Valgrind on ${{ matrix.os }} runs-on: ${{ matrix.os }} + if: github.event_name == 'push' || (github.event_name == 'pull_request' && github.event.pull_request.head.repo.full_name != github.repository) strategy: matrix: include: diff --git a/.github/workflows/wasm.yml b/.github/workflows/wasm.yml index 3e2c6e8..eab0977 100644 --- a/.github/workflows/wasm.yml +++ b/.github/workflows/wasm.yml @@ -1,9 +1,11 @@ on: push: + pull_request: name: "wasm" jobs: build_wasm: name: Basic WASM build + if: github.event_name == 'push' || (github.event_name == 'pull_request' && github.event.pull_request.head.repo.full_name != github.repository) runs-on: ubuntu-latest steps: - uses: actions/checkout@v3 diff --git a/.github/workflows/windows.yml b/.github/workflows/windows.yml index bfca14d..fa13aab 100644 --- a/.github/workflows/windows.yml +++ b/.github/workflows/windows.yml @@ -1,9 +1,11 @@ on: push: + pull_request: name: "windows" jobs: build_windows: name: Building Windows + if: github.event_name == 'push' || (github.event_name == 'pull_request' && github.event.pull_request.head.repo.full_name != github.repository) runs-on: windows-latest steps: - uses: actions/checkout@v3