Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spell Filter doesn't work #61

Open
adya opened this issue Nov 20, 2024 · 2 comments
Open

Spell Filter doesn't work #61

adya opened this issue Nov 20, 2024 · 2 comments
Assignees
@adya
Labels
bug Something isn't working feedback Created from user's feedback

Comments

@adya
Copy link
Collaborator

adya commented Nov 20, 2024

has_form appears to not detect Spells. This also affects ExclusiveGroup
@adya adya added the bug Something isn't working label Nov 20, 2024
@adya adya self-assigned this Nov 20, 2024
@adya adya added the feedback Created from user's feedback label Dec 19, 2024
@adya
Copy link
Collaborator Author

adya commented Dec 19, 2024

It works. The problem is that for_each_form actually delays adding Spells (and other forms) to NPC and instead collects them in a temporary vector. This causes all has_form filters to not find the previously added form of the same type (e.g. Spells can't filter by other distributed Spells).

@adya
Copy link
Collaborator Author

adya commented Dec 20, 2024

This will most likely be fixed after #58, when SPID will hold information about distributed entries and will be able to check both cached distribution and the actual NPC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adya adya

Labels
bug Something isn't working feedback Created from user's feedback
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@adya