Skip to content

Commit e790281

Browse files
authored
[PBIOS-258] Remove images from repo (#273)
## Summary Remove images from repo ## Additional Details - [Runway Story](https://nitro.powerhrg.com/runway/backlog_items/PBIOS-258) - [Optional: add more details] ## Screenshots (for UI stories: show before/after changes) | Before | After | | --------------------------------- | --------------------------------- | | [Before Pic] | [After Pic] | ## Breaking Changes [Yes/No (Explain)] ## Testing [Insert testing details or N/A] ## Checklist - [ ] **LABELS** - Add a label: `breaking`, `bug`, `improvement`, `documentation`, or `enhancement`. See [Labels](https://github.com/powerhome/playbook-apple/labels) for descriptions. - [ ] **SCREENSHOTS** - Please add a screenshot or two. For UI changes, you MUST provide before and after screenshots. - [ ] **RELEASES** - Add the appropriate label: `Ready for Testing` / `Ready for Release` - [ ] **TESTING** - Have you tested your story?
1 parent 35bd27c commit e790281

12 files changed

+10
-21
lines changed

Contribution.md

+7-4
Original file line numberDiff line numberDiff line change
@@ -74,18 +74,21 @@ In addition to the default linting rules, Playbook Swift enforces a indentation
7474
* To run SwiftFormat manually, use the plugin:
7575
* Right click `PlaybookSwift` in the Project Navigator
7676
* Click SwiftFormatPlugin
77-
<br />![Alt text](swift-format-plugin.png)
77+
<br />![swift-format-plugin](https://github.com/powerhome/PlaybookSwift/assets/60269827/fa5fdfcc-b430-46f4-b8cd-0b6f1758bbd0)
7878
* Click Run
79-
<br />![Alt text](swift-format-click-run.png)
79+
<br />![swift-format-click-run](https://github.com/powerhome/PlaybookSwift/assets/60269827/6f55d10a-39a3-43fc-8b66-6134f4186bea)
80+
8081

8182
These rules will also be enforced before you commit via [pre-commit](https://pre-commit.com/).
8283

8384
* After installing pre-commit via `brew install pre-commit && pre-commit install`, the first time you try to commit, it will take some time to install the hooks:
84-
<br /><br />![Alt text](swift-rules.png)
85+
<br /><br />![swift-rules](https://github.com/powerhome/PlaybookSwift/assets/60269827/43860663-900b-4ffc-9636-cc1770343efc)
86+
8587

8688

8789
* pre-commit will check for several rules and auto-corrects any violations. You will have to commit again if it finds an error. In the example below, one file did not have proper indentation which SwiftFormat detected and corrected:
88-
<br /><br />![Alt text](swift-format-violations.png)
90+
<br /><br />![swift-format-violations](https://github.com/powerhome/PlaybookSwift/assets/60269827/80d86b5b-bfdc-4be5-a10b-1744772f3d99)
91+
8992

9093
<br />
9194
<br />

IDETemplateMacros.plist

-12
This file was deleted.

Installation.md

+2-3
Original file line numberDiff line numberDiff line change
@@ -8,13 +8,12 @@
88

99
### Playbook Swift can be added via the Swift Package Manager
1010

11-
<!--![Package Manager Popup](pkgmgr-pop.png)-->
12-
<img src="pkgmgr-pop.png" height=200px />
11+
![pkgmgr-pop](https://github.com/powerhome/PlaybookSwift/assets/60269827/6319e924-252f-4ee3-8a05-5dbffa498a6b)
12+
1313

1414
1. Search for: `[email protected]:powerhome/PlaybookSwift.git`
1515
1. Choose `Add Package`
1616
2. In Xcode, Choose `Packages > Resolve Package Versions`
17-
<!-- ![Alt text](xcode-resolve-deps.png)-->
1817
3. In your Swift view file:
1918
```swift
2019
import Playbook

README.md

+1-2
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ Follow our [installation guide](Installation.md) to setup Playbook Swift in your
1616

1717
Playbook Swift contains the app named `PlaybookShowcase`; providing examples of each component. PlaybookShowcase can be launched within the XCode simulator, side-loaded, or downloaded to your device.
1818

19-
<img src="./playbook-showcase.png" height="500px" />
19+
<img width="316" alt="playbook-showcase" src="https://github.com/powerhome/PlaybookSwift/assets/60269827/aea56f5f-3f36-475a-af8b-4563cd14b8ca">
2020

2121

2222

@@ -28,4 +28,3 @@ Want to contribute to Playbook Swift? Check out our [contribution guidelines](Co
2828
# Copyright & License
2929

3030
Code released under [ISC License](License.md)
31-

pkgmgr-pop.png

-82.4 KB
Binary file not shown.

playbook-showcase.png

-261 KB
Binary file not shown.

swift-format-click-run.png

-31.8 KB
Binary file not shown.

swift-format-plugin.png

-96.9 KB
Binary file not shown.

swift-format-violations.png

-48.4 KB
Binary file not shown.

swift-rules.png

-76.7 KB
Binary file not shown.

upload-symbols

-261 KB
Binary file not shown.

xcode-resolve-deps.png

-310 KB
Binary file not shown.

0 commit comments

Comments
 (0)