Code feedback

Author: schloerke

shiny/api-examples/remove_accordion_panel/app-core.py

@@ -27,7 +27,7 @@ def make_panel(letter: str) -> ui.AccordionPanel:
 
 def server(input: Inputs, output: Outputs, session: Session):
     # Copy the list for user
-    user_choices = list(choices)
+    user_choices = choices.copy()
 
     @reactive.effect
     @reactive.event(input.remove_panel)

shiny/api-examples/remove_accordion_panel/app-express.py

@@ -20,19 +20,16 @@
             f"Some narrative for section {letter}"
 
 
-user_choices = list(choices)
-
-
 @reactive.effect
 @reactive.event(input.remove_panel)
 def _():
-    if len(user_choices) == 0:
+    if len(choices) == 0:
         ui.notification_show("No more panels to remove!")
         return
 
-    ui.remove_accordion_panel("acc", f"Section {user_choices.pop()}")
+    ui.remove_accordion_panel("acc", f"Section {choices.pop()}")
 
     label = "No more panels to remove!"
-    if len(user_choices) > 0:
-        label = f"Remove Section {user_choices[-1]}"
+    if len(choices) > 0:
+        label = f"Remove Section {choices[-1]}"
     ui.update_action_button("remove_panel", label=label)