Skip to content

Redundant install instructions in CI? #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tylerriccio33 opened this issue Apr 23, 2025 · 3 comments
Closed

Redundant install instructions in CI? #168

tylerriccio33 opened this issue Apr 23, 2025 · 3 comments

Comments

@tylerriccio33
Copy link
Contributor

In the github actions config we install the deps and then separately install the test deps. I feel like the first should cover the second right? I don't see why not. However, when I didn't add pytest-randomly and pytest-xdist to the test dependencies in the second step, I got errors saying they were missing, despite them being dev deps.

Any ideas?

- name: Install dependencies run: | pip install -e '.[dev]' - name: Install test dependencies run: | pip install pytest pytest-randomly pytest-xdist pytest-cov pytest-snapshot pandas polars ibis-framework[duckdb,mysql,postgres,sqlite]>=9.5.0 chatlas requests shiny

@rich-iannone
Copy link
Member

I think we need to rework the dependencies setup in pyproject.toml. It should probably be closer in configuration to one used in Great Tables: https://github.com/posit-dev/great-tables/blob/main/pyproject.toml. And there’s some unfortunate duplication and mismatched min version requirements in our current setup (should be addressed if adopting a similar setup as GT).

I don’t think we need to keep dependency groups unless we move to UV in CI (which should be done soon).

Do you feel comfortable taking this one on?

@tylerriccio33
Copy link
Contributor Author

Yea I can take this if you want to assign it, shouldn't be that bad

@rich-iannone
Copy link
Member

Fixed by #94

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants