support passing connect_user object to downstream functions

we still support GUID string for now

Author: karawoo

R/connect.R

@@ -495,8 +495,9 @@ Connect <- R6::R6Class(
     # users -----------------------------------------------
 
     #' @description Get user details.
-    #' @param guid The user GUID.
+    #' @param guid The user GUID or a `connect_user` object.
     user = function(guid) {
+      guid <- get_user_guid(guid)
       prepend_class(self$GET(v1_url("users", guid)), "connect_user")
     },
 
@@ -589,8 +590,9 @@ Connect <- R6::R6Class(
     },
 
     #' @description Lock a user.
-    #' @param user_guid User GUID.
+    #' @param user_guid User GUID or a `connect_user` object.
     users_lock = function(user_guid) {
+      user_guid <- get_user_guid(user_guid)
       path <- v1_url("users", user_guid, "lock")
       message(path)
       self$POST(
@@ -600,8 +602,9 @@ Connect <- R6::R6Class(
     },
 
     #' @description Unlock a user.
-    #' @param user_guid User GUID.
+    #' @param user_guid User GUID or a `connect_user` object.
     users_unlock = function(user_guid) {
+      user_guid <- get_user_guid(user_guid)
       path <- v1_url("users", user_guid, "lock")
       self$POST(
         path = path,
@@ -610,9 +613,10 @@ Connect <- R6::R6Class(
     },
 
     #' @description Update a user.
-    #' @param user_guid User GUID.
+    #' @param user_guid User GUID or a `connect_user` object.
     #' @param ... User fields.
     users_update = function(user_guid, ...) {
+      user_guid <- get_user_guid(user_guid)
       path <- v1_url("users", user_guid)
       self$PUT(
         path = path,
@@ -645,16 +649,18 @@ Connect <- R6::R6Class(
 
     #' @description Add a group member.
     #' @param group_guid The group GUID.
-    #' @param user_guid The user GUID.
+    #' @param user_guid The user GUID or a `connect_user` object.
     group_member_add = function(group_guid, user_guid) {
+      user_guid <- get_user_guid(user_guid)
       path <- v1_url("groups", group_guid, "members")
       self$POST(path, body = list(user_guid = user_guid))
     },
 
     #' @description Remove a group member.
     #' @param group_guid The group GUID.
-    #' @param user_guid The user GUID.
+    #' @param user_guid The user GUID or a `connect_user` object.
     group_member_remove = function(group_guid, user_guid) {
+      user_guid <- get_user_guid(user_guid)
       path <- v1_url("groups", group_guid, "members", user_guid)
       self$DELETE(path)
     },

R/content.R

@@ -226,10 +226,14 @@ Content <- R6::R6Class(
       self$get_connect()$GET(url)
     },
     #' @description Add a principal to the ACL for this content.
-    #' @param principal_guid GUID for the target user or group.
+    #' @param principal_guid GUID for the target user or group. When
+    #'   `principal_type = "user"`, can also be a `connect_user` object.
     #' @param principal_type Acting on user or group.
     #' @param role The kind of content access.
     permissions_add = function(principal_guid, principal_type, role) {
+      if (principal_type == "user") {
+        principal_guid <- get_user_guid(principal_guid)
+      }
       url <- v1_url("content", self$get_content()$guid, "permissions")
       self$get_connect()$POST(
         url,
@@ -242,10 +246,14 @@ Content <- R6::R6Class(
     },
     #' @description Alter a principal in the ACL for this content.
     #' @param id The target identifier.
-    #' @param principal_guid GUID for the target user or group.
+    #' @param principal_guid GUID for the target user or group. When
+    #'   `principal_type = "user"`, can also be a `connect_user` object.
     #' @param principal_type Acting on user or group.
     #' @param role The kind of content access.
     permissions_update = function(id, principal_guid, principal_type, role) {
+      if (principal_type == "user") {
+        principal_guid <- get_user_guid(principal_guid)
+      }
       url <- v1_url("content", self$get_content()$guid, "permissions", id)
       self$get_connect()$PUT(
         url,
@@ -1048,6 +1056,7 @@ content_update_access_type <- function(
 #' @rdname content_update
 #' @export
 content_update_owner <- function(content, owner_guid) {
+  owner_guid <- get_user_guid(owner_guid)
   content_update(content = content, owner_guid = owner_guid)
 }
 
@@ -1161,6 +1170,7 @@ content_add_user <- function(content, guid, role = c("viewer", "owner")) {
   validate_R6_class(content, "Content")
   role <- .define_role(role)
 
+  guid <- purrr::map_chr(guid, get_user_guid)
   purrr::map(guid, ~ .content_add_permission_impl(content, "user", .x, role))
 
   return(content)
@@ -1228,6 +1238,7 @@ content_add_group <- function(content, guid, role = c("viewer", "owner")) {
 #' @export
 content_delete_user <- function(content, guid) {
   validate_R6_class(content, "Content")
+  guid <- purrr::map_chr(guid, get_user_guid)
   purrr::map(
     guid,
     ~ .content_delete_permission_impl(
@@ -1281,6 +1292,7 @@ content_delete_group <- function(content, guid) {
 #' @export
 get_user_permission <- function(content, guid, add_owner = TRUE) {
   validate_R6_class(content, "Content")
+  guid <- get_user_guid(guid)
   res <- .get_permission(content, "user", guid, add_owner = add_owner)
   if (length(res) > 0) {
     return(res[[1]])

R/user.R

@@ -32,3 +32,28 @@ user_guid_from_username <- function(client, username) {
     return(res[[1]]$guid)
   }
 }
+
+#' Extract User GUID
+#'
+#' Helper function to extract a user GUID from either a character string or a
+#' `connect_user` object.
+#'
+#' @param user Either a character string containing a user GUID or a
+#'   `connect_user` object (as returned by `Connect$user()` or `Connect$users()`)
+#'
+#' @return A character string containing the user GUID
+#'
+#' @keywords internal
+get_user_guid <- function(user) {
+  if (is.character(user)) {
+    return(user)
+  } else if (inherits(user, "connect_user")) {
+    if (!is.null(user$guid)) {
+      return(user$guid)
+    } else {
+      stop("connect_user object does not contain a guid field")
+    }
+  } else {
+    stop("user must be either a character string (GUID) or a connect_user object")
+  }
+}