Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for Gagan #6

Open
9 tasks
SamEdwardes opened this issue Aug 15, 2023 · 0 comments
Open
9 tasks

Update for Gagan #6

SamEdwardes opened this issue Aug 15, 2023 · 0 comments
Assignees

Comments

@SamEdwardes
Copy link
Contributor

SamEdwardes commented Aug 15, 2023

Hey @gsingh91, I am creating this issue to provide an update on the work that occurred while you were on vacation and to document the remaining work that needs to be done.

Important updates:

  • I have merged all changes into the main branch. For all future changes, please create a new branch from main, and then us a PR to bring the changes back in.
  • I have reorganized the repo so that each activity and each solution has its own directory:
.
├── LICENSE.md
├── materials
│   ├── activities
│   │   ├── 01-reading-data
│   │   ├── 02-data-exploration-and-validation
│   │   ├── 03-model-training
│   │   ├── 04-model-monitoring
│   │   └── 05-shiny-app
│   └── solutions
│       ├── 01-reading-data
│       ├── 02-data-exploration-and-validation
│       ├── 03-model-training
│       ├── 04-model-monitoring
│       ├── 05-shiny-app
│       ├── appendix
│       └── imgs
└── README.md
  • I made a small update to your modelling notebook so that it writes the features to the SQL database. I am doing this to use these features from Shiny App. This simplifies the shiny app since I do not need to repeat the data cleaning (349d689).

To do

@gsingh91 can you please make sure these remaining activities are done. For anything that requires a change, please go ahead and max the update directly. I will not have any time to make updates between when I am back from vacation and when conf starts.

  • Finalize your activity notebook and solution for 03-modelling.
  • Finalize your activity notebook and solution for 04-model-monitoring.
  • Run and test all of your code using the conf infrastructure.
  • Review Sam's sections. Please review both the activity and solution directories. Check (1) you can run the code, (2) the activities make sense and are at the right level of detail (3) for typos or other errors. Please make any required changes directly, as I won't have time to make the updates before conf once I am back from vacation.
    • 01-reading-data
    • 02-data-exploration-and-validation
    • 05-shiny-app
  • Review the slides and complete any outstanding items documented in the comments there.
  • Review the slides for typos, completeness, and any other issues.

I will continue to update this issue until I am off on my vacation starting August 21st.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants