Skip to content

Commit de9e9dd

Browse files
committed
fix(ci): install jq via apt and remove from install-action
1 parent 1531df5 commit de9e9dd

3 files changed

Lines changed: 23 additions & 4 deletions

File tree

.github/workflows/ci.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,12 +16,12 @@ jobs:
1616
- name: Install fish
1717
run: |
1818
sudo apt-get update
19-
sudo apt-get install -y fish
19+
sudo apt-get install -y fish jq
2020
2121
- name: Install formatter and lint tools
2222
uses: taiki-e/install-action@v2
2323
with:
24-
tool: shfmt,shellcheck,jq,stylua,taplo-cli
24+
tool: shfmt,shellcheck,stylua,taplo-cli
2525

2626
- name: Run format check
2727
run: make format
@@ -36,12 +36,12 @@ jobs:
3636
- name: Install fish
3737
run: |
3838
sudo apt-get update
39-
sudo apt-get install -y fish
39+
sudo apt-get install -y fish jq
4040
4141
- name: Install formatter and lint tools
4242
uses: taiki-e/install-action@v2
4343
with:
44-
tool: shfmt,shellcheck,jq,stylua,taplo-cli
44+
tool: shfmt,shellcheck,stylua,taplo-cli
4545

4646
- name: Run lint
4747
run: make lint

docs/tasks/lessons.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,3 +10,5 @@
1010
- Prevention rule: after expanding CI scope, always rename workflow file/title/job names to match current responsibilities before finishing.
1111
- User correction pattern: when CI/workflow naming is unclear, prioritize explicit, generic naming (`ci.yml`, `CI`) that reflects the full scope.
1212
- Prevention rule: before finishing CI edits, verify workflow filename/title and job names are semantically aligned with all executed tasks.
13+
- User correction pattern: GitHub Actions tool installers can silently fall back to different install paths with incompatible package semantics (e.g., cargo-binstall for non-Rust tools).
14+
- Prevention rule: when using `taiki-e/install-action`, verify each tool is actually supported; install unsupported tools (like `jq`) via OS package manager explicitly.

docs/tasks/todo.md

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -71,3 +71,20 @@
7171
- Added `.config/ghostty/themes/Cursor Dark` with Cursor Dark-aligned palette and UI colors
7272
- Updated `.config/ghostty/config` to use `theme = Cursor Dark`
7373
- Removed direct `background` override from config to avoid theme color conflicts
74+
75+
---
76+
77+
# CI install-action jq Failure Fix
78+
79+
## Plan
80+
81+
- [x] Reproduce and pinpoint the CI failure root cause from logs and workflow config
82+
- [x] Update workflow tool installation to avoid cargo-binstall jq failure
83+
- [x] Run local verification commands relevant to format/lint workflow
84+
- [x] Document review results
85+
86+
## Review
87+
88+
- Root cause: `taiki-e/install-action@v2` does not support `jq`, causing fallback to `cargo-binstall` and failure on non-binary `jq` crate
89+
- Fix: install `jq` via `apt-get` and remove `jq` from install-action tool list in both CI jobs
90+
- Validation: local `make format` and `make lint` passed

0 commit comments

Comments
 (0)