improve rpc request result performance #1586
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyscott18
commented
Mar 7, 2025
| async () => { | ||
| const requestHashes = requests.map((request) => | ||
| crypto.createHash("md5").update(request).digest("hex"), |
There was a problem hiding this comment.
@typedarray Need to be very careful that this matches the previous hashes that we generated by postgres. I added a test for this.
There was a problem hiding this comment.
Seems good, but we should double check
- Make sure any pre-processing we're doing (casing, sorting keys?) is the same as before
- Casing, we're storing this in a TEXT column
- Any possibility that the strings were changed by the driver before making it to PG (in the old imp)
There was a problem hiding this comment.
The request is preprocessed before making it to this function.
ponder/packages/core/src/sync/transport.ts
Lines 84 to 86 in 689156e
Comment on lines
+139
to
+142
| // Note: we don't cache request that failed or returned "0x". See more about "0x" below. | ||
| .filter( | ||
| ({ result }) => result?.success && result.returnData !== "0x", | ||
| ) |
There was a problem hiding this comment.
@typedarray I don't think we should cache failed requests and just re-request them
kyscott18
changed the title
…ponder into kjs/rpc-request-results
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improved several performance characteristics surrounding cached rpc requests
requestcolumn fromrpc_request_resultstablepruneRpcRequestResultsmulticallrequests