feat(tui): show lock indicator for locked Milltime time entries#97
Merged
alxhall merged 1 commit intoponbac:masterfrom Mar 6, 2026
Merged
feat(tui): show lock indicator for locked Milltime time entries#97alxhall merged 1 commit intoponbac:masterfrom
alxhall merged 1 commit intoponbac:masterfrom
Conversation
|
@alxhall is attempting to deploy a commit to the ponbac's projects Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
Owner
|
Codex Review: Didn't find any major issues. Keep them coming! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces support for "locked" time entries by adding an attestation/lock level to entries, preventing editing or deletion of locked items, and updating the UI to visually indicate locked entries. The changes ensure that entries with an attestation level (week or month) cannot be modified, and provide clear feedback to users when such actions are attempted.
Entry Locking and Attestation Support
AttestLevelenum to represent the attestation/lock status of a time entry, with methods for conversion and lock checking. TheTimeEntrystruct now includes anattest_levelfield, and entries default to unlocked unless specified.Edit and Delete Guarding
Updated edit and delete logic in
Appand runtime view handlers to check if the focused entry is locked before allowing modifications. If locked, a status message is shown and the action is blocked.User Feedback
Added status messages for locked entry edit and delete attempts, providing immediate feedback to users when such actions are not permitted.
UI Updates