fix(tui): fix activities fetch issue and let backspace key clear input fields for non-running timer#92
Closed
alxhall wants to merge 2 commits intoponbac:masterfrom
Closed
Conversation
|
@alxhall is attempting to deploy a commit to the ponbac's projects Team on Vercel. A member of the Team first needs to authorize it. |
Owner
|
Replaced with #94 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Greptile Summary
Fixed activity fetching in edit mode by refactoring the Enter key handler to async, ensuring activities are fetched from the API when editing entries with projects that aren't in the cache. Also fixed double key event processing by filtering for
KeyEventKind::Press, cleared activity search state when entering the activity picker, and added Backspace keybinding to clear project/activity or note when the timer is stopped.Key changes:
handle_entry_edit_enterinto async version that fetches activities on-demand using the activity cacheKeyEventKind::Pressfiltering to prevent processing both key press and release eventsclear_project_activity()andclear_note()methodsConfidence Score: 5/5
Important Files Changed
Last reviewed commit: 30fa326
(5/5) You can turn off certain types of comments like style here!