Skip to content

fix: timeline entry min height issues#101

Merged
ponbac merged 2 commits intomasterfrom
min-height-issues
Mar 4, 2026
Merged

fix: timeline entry min height issues#101
ponbac merged 2 commits intomasterfrom
min-height-issues

Conversation

@ponbac
Copy link
Owner

@ponbac ponbac commented Mar 4, 2026

No description provided.

@vercel
Copy link

vercel bot commented Mar 4, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
toki2 Ready Ready Preview, Comment Mar 4, 2026 1:00pm

Request Review

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2900d85b73

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +184 to +185
if (!Number.isFinite(startMs) || !Number.isFinite(endMs) || endMs <= startMs) {
continue;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep zero-duration entries visible in timeline

This guard now skips any entry where endMs <= startMs, which causes entries with identical start/end times to disappear from the timeline entirely. The create/edit flows currently allow users to submit equal start and end times, so these records can exist and were previously still rendered with a minimum block height; after this change they cannot be seen or clicked from the timeline view. Handle endMs === startMs as a tiny visual block instead of dropping it.

Useful? React with 👍 / 👎.

@ponbac ponbac merged commit e5fe59b into master Mar 4, 2026
7 checks passed
@ponbac ponbac deleted the min-height-issues branch March 4, 2026 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant