Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide source of the website #1

Open
waldyrious opened this issue Jan 22, 2020 · 6 comments
Open

Provide source of the website #1

waldyrious opened this issue Jan 22, 2020 · 6 comments
Assignees

Comments

@waldyrious
Copy link

It should be possible to submit improvements to the website itself. I'm not sure how it's hosted, but if using Github Pages is an option, then it could be either a separate repository, or a separate branch in this repo.

For reference, I was looking to propose a style change to improve the readability of "quick reference" table at https://polyformproject.org/licenses/.

@kemitchell
Copy link
Member

@waldyrious polyformproject.org is on WordPress. Please feel free to open issues for any improvements you have in mind!

@kemitchell kemitchell self-assigned this Jan 22, 2020
@waldyrious
Copy link
Author

waldyrious commented Jan 22, 2020

That's what I assumed, from the polyform-wordpress-theme repo. For a static website, I'd say that GitHub pages is a better fit. (It would certainly easier to contribute to.)

Anyway, I just wanted to suggest an improved styling for the table. Something like this:

td { padding: 0.1em 0.2em; border: 1px solid LightGrey; }
table { border-collapse: collapse; }

Here's the result. Before:
Screenshot 2020-01-22 at 23 37 31

After:
Screenshot 2020-01-22 at 23 38 17

I would also suggest changing the cells in the first column from <td> to <th>, so that the others could be styled as td { text-align: center; }, which would also help with readability IMO.

@kemitchell
Copy link
Member

Would you like to make a PR to https://github.com/polyformproject/polyform-wordpress-theme?

@waldyrious
Copy link
Author

@kemitchell Sure. Would you mind first making the <td><th> change in the HTML as I suggested above? That way I can address the second suggestion as well.

@mostaphaRoudsari
Copy link

For a static website, I'd say that GitHub pages is a better fit. (It would certainly easier to contribute to.)

I agree and I could have sent a PR to fix this now. Not sure how to do it in a word-press-theme.

@kemitchell, this issue should probably be transferred to (https://github.com/polyformproject/polyform-wordpress-theme). That will make it easier to find.

@kemitchell kemitchell transferred this issue from polyformproject/polyform-licenses Apr 9, 2020
@kemitchell
Copy link
Member

kemitchell commented Apr 10, 2020

I definitely floated GitHub pages early on. And a lot of people know their way around GitHub. But the decision at the time was that more of the folks liable to contribute, and who did in fact create the polyformproject.org you see now, would be self-sufficient on WordPress.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants