refactor: Move hive partitioning outside of readers #20203
Draft
+291
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a very early stage PR exploring whether it is possible to take the hive partitioning out of the readers. This will also make the Hive partitioning complete file type agnostic. Currently, this PR does not do anything unless `POLARS_NEW_HIVE` is set to `1`. Here is a rough todo list. - [x] Row Indexes - [x] Include File Paths - [x] Projection Pushdown - [ ] Slicing - [ ] Hive Predicates - [ ] Lazy Loading of Non-Hive data - [ ] Allow Missing Columns - [ ] Other file types besides Parquet - [ ] New streaming engine sink
github-actions
bot
added
internal
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #20203 +/- ##
==========================================
- Coverage 79.63% 79.56% -0.08%
==========================================
Files 1564 1566 +2
Lines 217804 218364 +560
Branches 2477 2475 -2
==========================================
+ Hits 173439 173731 +292
- Misses 43796 44066 +270
+ Partials 569 567 -2 ☔ View full report in Codecov by Sentry. |
ritchie46
reviewed
Dec 7, 2024
| } | ||
|
|
||
| pub struct HiveExec { | ||
| sources: ScanSources, |
There was a problem hiding this comment.
I think we can accept a generic here. One that take the filtered out paths and creates a Box<dyn Executror>. Then this node doesn't have to know anything about the actual implementations of parquet, csv, etc. The planner deals with that.
coastalwhite
force-pushed
the
refactor/new-hive
branch
from
bd71732 to
99d6a93
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very early stage PR exploring whether it is possible to take the hive partitioning out of the readers. This will also make the Hive partitioning complete file type agnostic.
Currently, this PR does not do anything unless
POLARS_NEW_HIVEis set to1.Here is a rough todo list.
ping @ritchie46, @nameexhaustion