Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

read_csv PanicException when pl.Decimal used in schema with invalid precision #18812

Open
2 tasks done
cmdlineluser opened this issue Sep 18, 2024 · 0 comments
Open
2 tasks done
Labels
bug Something isn't working needs triage Awaiting prioritization by a maintainer python Related to Python Polars

Comments

@cmdlineluser
Copy link
Contributor

cmdlineluser commented Sep 18, 2024

Checks

  • I have checked that this issue has not already been reported.
  • I have confirmed this bug exists on the latest version of Polars.

Reproducible example

import polars as pl

pl.read_csv(b"a,b\n1,2", schema_overrides={"b": pl.Decimal(39)})
# thread 'polars-0' panicked at crates/polars-core/src/datatypes/dtype.rs:545:41:
# called `Result::unwrap()` on an `Err` value: InvalidOperation(ErrString("decimal precision should be <= 38 & >= 1"))
# PanicException: called `Result::unwrap()` on an `Err` value: InvalidOperation(ErrString("decimal precision should be <= 38 & >= 1"))

Log output

No response

Issue description

Just a panic instead of raising the underlying error.

Expected behavior

InvalidOperationError

Installed versions

--------Version info---------
Polars:               1.7.1
Index type:           UInt32
Platform:             macOS-13.6.1-arm64-arm-64bit
Python:               3.12.2 (main, Feb  6 2024, 20:19:44) [Clang 15.0.0 (clang-1500.1.0.2.5)]

----Optional dependencies----
adbc_driver_manager:  <not installed>
cloudpickle:          <not installed>
connectorx:           <not installed>
deltalake:            <not installed>
fastexcel:            <not installed>
fsspec:               <not installed>
gevent:               <not installed>
great_tables:         <not installed>
hvplot:               <not installed>
matplotlib:           <not installed>
nest_asyncio:         <not installed>
numpy:                1.26.4
openpyxl:             <not installed>
pandas:               2.2.1
pyarrow:              15.0.2
pydantic:             <not installed>
pyiceberg:            <not installed>
sqlalchemy:           <not installed>
torch:                <not installed>
xlsx2csv:             <not installed>
xlsxwriter:           <not installed>
@cmdlineluser cmdlineluser added bug Something isn't working needs triage Awaiting prioritization by a maintainer python Related to Python Polars labels Sep 18, 2024
@cmdlineluser cmdlineluser changed the title read_csv PanicException when pl.Decimal in schema given invalid precision. read_csv PanicException when pl.Decimal used in schema with invalid precision Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs triage Awaiting prioritization by a maintainer python Related to Python Polars
Projects
None yet
Development

No branches or pull requests

1 participant