Soften app host failure message (#50)

* Soften app host failure message

The way we detect app hosts triggers more often than we expected, especially in async tests, so let's make it sound a bit more informational instead of a loud warning that makes the false positive sound more definitive.

* wip

* Update XCTFail.swift

---------

Co-authored-by: Brandon Williams <[email protected]>

Author: stephencelis

Sources/XCTestDynamicOverlay/XCTFail.swift

@@ -76,36 +76,20 @@ import Foundation
       guard callStack.allSatisfy({ frame in !isTestFrame(frame) })
       else { return }
 
-      let displayName =
-        Bundle.main.object(forInfoDictionaryKey: "CFBundleDisplayName") as? String
-        ?? Bundle.main.object(forInfoDictionaryKey: kCFBundleNameKey as String) as? String
-        ?? "Unknown host application"
-
-      let bundleIdentifier = Bundle.main.bundleIdentifier ?? "Unknown bundle identifier"
-
       if !message.contains(where: \.isNewline) {
         message.append(" …")
       }
 
       message.append(
         """
 
+        
+        ━━┉┅
+        Note: This failure was emitted from tests running in a host application\
+        \(Bundle.main.bundleIdentifier.map { " (\($0))" }).
 
-        ┏━━━━━━━━━━━━━━━━━┉┅
-        ┃ ⚠︎ Warning:
-        ┃
-        ┃ This failure was emitted from a host application outside the test stack.
-        ┃
-        ┃   Host application:
-        ┃     \(displayName) (\(bundleIdentifier))
-        ┃
-        ┃ The host application may have emitted this failure when it first launched,
-        ┃ outside this current test that happens to be running.
-        ┃
-        ┃ Consider setting the test target's host application to "None," or prevent
-        ┃ the host application from performing the code path that emits failure.
-        ┗━━━━━━━━━━━━━━━━━┉┅
-            ▀▄▀▄▀▄▀▄▀▄▀▄▀▄▀▄▀▄▀▄▀▄▀▄▀▄▀▄▀▄▀▄▀▄
+        This can lead to false positives, where failures could have emitted from live application \
+        code at launch time, and not from the current test.
 
         For more information (and workarounds), see "Testing gotchas":