wip

Author: stephencelis

Examples/TicTacToe/tic-tac-toe/Sources/LoginCore/LoginCore.swift

@@ -15,12 +15,16 @@ public struct Login: ReducerProtocol, Sendable {
     public init() {}
   }
 
-  public enum Action: BindableAction, Equatable {
+  public enum Action: Equatable {
     case alert(PresentationAction<AlertAction>)
-    case binding(BindingAction<State>)
-    case loginButtonTapped
     case loginResponse(TaskResult<AuthenticationResponse>)
     case twoFactor(PresentationAction<TwoFactor.Action>)
+    case view(View)
+
+    public enum View: BindableAction, Equatable {
+      case binding(BindingAction<State>)
+      case loginButtonTapped
+    }
   }
 
   public enum AlertAction: Equatable, Sendable {}
@@ -30,16 +34,12 @@ public struct Login: ReducerProtocol, Sendable {
   public init() {}
 
   public var body: some ReducerProtocol<State, Action> {
-    BindingReducer()
+    BindingReducer(action: /Action.view)
     Reduce { state, action in
       switch action {
       case .alert:
         return .none
 
-      case .binding:
-        state.isFormValid = !state.email.isEmpty && !state.password.isEmpty
-        return .none
-
       case let .loginResponse(.success(response)):
         state.isLoginRequestInFlight = false
         if response.twoFactorRequired {
@@ -52,7 +52,14 @@ public struct Login: ReducerProtocol, Sendable {
         state.isLoginRequestInFlight = false
         return .none
 
-      case .loginButtonTapped:
+      case .twoFactor:
+        return .none
+
+      case .view(.binding):
+        state.isFormValid = !state.email.isEmpty && !state.password.isEmpty
+        return .none
+
+      case .view(.loginButtonTapped):
         state.isLoginRequestInFlight = true
         return .run { [email = state.email, password = state.password] send in
           await send(
@@ -65,9 +72,6 @@ public struct Login: ReducerProtocol, Sendable {
             )
           )
         }
-
-      case .twoFactor:
-        return .none
       }
     }
     .ifLet(\.$alert, action: /Action.alert)

Examples/TicTacToe/tic-tac-toe/Sources/LoginSwiftUI/LoginView.swift

@@ -31,7 +31,7 @@ public struct LoginView: View {
   }
 
   public var body: some View {
-    WithViewStore(self.store, observe: ViewState.init) { viewStore in
+    WithViewStore(self.store, observe: ViewState.init, send: { .view($0) }) { viewStore in
       Form {
         Text(
           """

Examples/TicTacToe/tic-tac-toe/Sources/LoginUIKit/LoginViewController.swift

@@ -200,11 +200,11 @@ extension Login.Action {
     case .alertDismissed:
       self = .alert(.dismiss)
     case let .emailChanged(email):
-      self = .set(\.$email, email ?? "")
+      self = .view(.set(\.$email, email ?? ""))
     case .loginButtonTapped:
-      self = .loginButtonTapped
+      self = .view(.loginButtonTapped)
     case let .passwordChanged(password):
-      self = .set(\.$password, password ?? "")
+      self = .view(.set(\.$password, password ?? ""))
     case .twoFactorDismissed:
       self = .twoFactor(.dismiss)
     }