fix(core): handle shutdown lock cleanup rejection#961
Open
realfishsam wants to merge 1 commit into
Open
Conversation
Contributor
Author
PR Review: PASS (NOT VERIFIED)What This DoesMakes server shutdown lock-file cleanup rejection-safe and idempotent so signal handling still exits after cleanup failures. Blast RadiusCore server startup/shutdown path only. Consumer VerificationBefore (base branch): After (PR branch): Test Results
FindingsNo blocking findings. PMXT Pipeline Check
Semver Impactpatch -- server shutdown robustness fix. RiskActual SIGINT/SIGTERM behavior with a failing lock-file removal was not reproduced; conclusion is from code path and passing build/tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #720
Test Plan