ch4: remove av table ref_count

We don't really tracek av tables' ref_count. We simply free all av
tables at finalize.

Rename MPIDIU_avt_destroy to MPIDIU_avt_finalize to better reflect its
role.

Author: hzhou

src/mpid/ch4/src/ch4_init.c

@@ -734,7 +734,7 @@ int MPID_Finalize(void)
 
     MPIDU_genq_private_pool_destroy(MPIDI_global.gpu_coll_pool);
 
-    MPIDIU_avt_destroy();
+    MPIDIU_avt_finalize();
 
     mpi_errno = MPIDU_Init_shm_finalize();
     MPIR_ERR_CHECK(mpi_errno);

src/mpid/ch4/src/ch4_proc.c

@@ -102,8 +102,6 @@ int MPIDIU_new_avt(int size, int *avtid)
     }
     MPIDI_global.avt_mgr.av_tables[*avtid] = new_av_table;
 
-    MPIR_cc_set(&MPIDI_global.avt_mgr.av_tables[*avtid]->ref_count, 0);
-
     MPIR_FUNC_EXIT;
     return mpi_errno;
 }
@@ -124,33 +122,6 @@ int MPIDIU_free_avt(int avtid)
     return mpi_errno;
 }
 
-int MPIDIU_avt_add_ref(int avtid)
-{
-    MPIR_FUNC_ENTER;
-
-    MPL_DBG_MSG_FMT(MPIDI_CH4_DBG_GENERAL, VERBOSE, (MPL_DBG_FDEST, " incr avtid=%d", avtid));
-    MPIR_cc_inc(&MPIDI_global.avt_mgr.av_tables[avtid]->ref_count);
-
-    MPIR_FUNC_EXIT;
-    return MPI_SUCCESS;
-}
-
-int MPIDIU_avt_release_ref(int avtid)
-{
-    int in_use;
-
-    MPIR_FUNC_ENTER;
-
-    MPL_DBG_MSG_FMT(MPIDI_CH4_DBG_GENERAL, VERBOSE, (MPL_DBG_FDEST, " decr avtid=%d", avtid));
-    MPIR_cc_decr(&MPIDI_global.avt_mgr.av_tables[avtid]->ref_count, &in_use);
-    if (!in_use) {
-        MPIDIU_free_avt(avtid);
-    }
-
-    MPIR_FUNC_EXIT;
-    return MPI_SUCCESS;
-}
-
 static void init_dynamic_av_table(void);
 static void destroy_dynamic_av_table(void);
 
@@ -178,7 +149,6 @@ int MPIDIU_avt_init(void)
 #endif
 
     MPIDI_global.avt_mgr.av_table0->size = size;
-    MPIR_cc_set(&MPIDI_global.avt_mgr.av_table0->ref_count, 1);
 
     for (int i = 0; i < size; i++) {
         MPIDI_global.avt_mgr.av_table0->table[i].is_local =
@@ -194,14 +164,13 @@ int MPIDIU_avt_init(void)
     return mpi_errno;
 }
 
-int MPIDIU_avt_destroy(void)
+int MPIDIU_avt_finalize(void)
 {
     MPIR_FUNC_ENTER;
 
     for (int i = 0; i < MPIDI_global.avt_mgr.n_avts; i++) {
         if (MPIDI_global.avt_mgr.av_tables[i] != NULL) {
-            MPIDIU_avt_release_ref(i);
-            /*TODO: Check all references is cleared and the entry is set to NULL */
+            MPIDIU_free_avt(i);
         }
     }
 

src/mpid/ch4/src/ch4_proc.h

@@ -22,10 +22,8 @@ int MPIDIU_get_n_avts(void);
 int MPIDIU_get_avt_size(int avtid);
 int MPIDIU_new_avt(int size, int *avtid);
 int MPIDIU_free_avt(int avtid);
-int MPIDIU_avt_add_ref(int avtid);
-int MPIDIU_avt_release_ref(int avtid);
 int MPIDIU_avt_init(void);
-int MPIDIU_avt_destroy(void);
+int MPIDIU_avt_finalize(void);
 int MPIDIU_get_node_id(MPIR_Comm * comm, int rank, int *id_p);
 
 #ifdef MPIDI_BUILD_CH4_UPID_HASH

src/mpid/ch4/src/ch4_types.h

@@ -185,7 +185,6 @@ typedef struct MPIDIG_acc_ack_msg_t {
 typedef MPIDIG_acc_ack_msg_t MPIDIG_get_acc_ack_msg_t;
 
 typedef struct {
-    MPIR_cc_t ref_count;
     int size;
     MPIDI_av_entry_t table[];
 } MPIDI_av_table_t;