Skip to content

Commit 2a39ad6

Browse files
committed
ch3: Remove unnecessary checks in process group close
These checks are not needed and lead to warnings due to set but unused variable.
1 parent 4ddcd20 commit 2a39ad6

File tree

1 file changed

+1
-11
lines changed

1 file changed

+1
-11
lines changed

src/mpid/ch3/src/mpidi_pg.c

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -938,7 +938,7 @@ int MPIDI_PG_Close_VCs( void )
938938
MPIR_FUNC_ENTER;
939939

940940
while (pg) {
941-
int i, inuse, n, i_start;
941+
int i, n, i_start;
942942

943943
MPL_DBG_MSG_S(MPIDI_CH3_DBG_DISCONNECT,VERBOSE,"Closing vcs for pg %s",
944944
(char *)pg->id );
@@ -955,10 +955,6 @@ int MPIDI_PG_Close_VCs( void )
955955
vc = &pg->vct[i];
956956
/* If the VC is myself then skip the close message */
957957
if (pg == MPIDI_Process.my_pg && i == MPIDI_Process.my_pg_rank) {
958-
/* XXX DJG FIXME-MT should we be checking this? */
959-
if (MPIR_Object_get_ref(vc) != 0) {
960-
MPIDI_PG_release_ref(pg, &inuse);
961-
}
962958
continue;
963959
}
964960

@@ -968,12 +964,6 @@ int MPIDI_PG_Close_VCs( void )
968964
MPIR_ERR_CHECK(mpi_errno);
969965
} else if (vc->state == MPIDI_VC_STATE_INACTIVE ||
970966
vc->state == MPIDI_VC_STATE_MORIBUND) {
971-
/* XXX DJG FIXME-MT should we be checking this? */
972-
if (MPIR_Object_get_ref(vc) != 0) {
973-
/* FIXME: If the reference count for the vc is not 0,
974-
something is wrong */
975-
MPIDI_PG_release_ref(pg, &inuse);
976-
}
977967
/* Inactive connections need to be marked
978968
INACTIVE_CLOSED, so that if a connection request
979969
comes in during the close protocol, we know to

0 commit comments

Comments
 (0)