-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scene not rendered in latest react-three/fiber #19
Comments
Hey, thanks a lot for looking into this and reporting the specific issues. I will try to fix this in the next few days. |
Let me know if I can help. I'm on the poimandres discord |
I upgraded to latest React/r3f was able to repro the |
Hi guys, |
Hi Slava and others, I appreciate the long wait - a bit of a crunch at work but I should have some cycles this week to wrap this up. |
Hey team any updates on this? Really keen to use this in a project. Thanks for the awesome work. |
Thanks for checking in again! Yeah the last month has been really busy at work, I am hoping that time management improves in the coming week. Really appreciating the wait - suspense related issues are super finicky to try and figure out, hence why I need to dig in a bit deeper on this. |
Hi, I am also very excited to use this in my project. Any updates? Thanks for amazing work! |
Ok, so I did some cleanup work and upgraded to React 18. As is, the To help with that, I added an I will try to wrap up the new work on re-adding Suspense soon, and maybe treat that as a |
Thank you so much!!! |
The update is not yet published to npm right? |
I did not push a new version to NPM yet, this is in a temporary state until I fix suspense 😅. |
Oh okay okay, Thanks. I did not meant to rush you btw:) |
Some more work in progress here: #23. I am moving the actual baking to work in a separate React root and WebGL context - this keeps logic a bit simpler (no need to clean up the temporary baker scene), and should plug into Suspense much better, because the process is completely independent of the suspended React tree. |
The latest version of
@react-three/fiber
prevents renderingModified the example sandbox to demonstrate
Tried solving the issue locally. There seems to be 2 issues:
sceneRef.current
isn't receiving a valuerunWorkflow
method gets called twice and errors in the withLightScene method (line 91)The text was updated successfully, but these errors were encountered: