Skip to content

Commit c2523e7

Browse files
committed
resolve feedback
Addresses phpstan#3613 (comment)
1 parent d472b91 commit c2523e7

File tree

1 file changed

+8
-20
lines changed

1 file changed

+8
-20
lines changed

src/Rules/Comparison/StrictComparisonOfDifferentTypesRule.php

Lines changed: 8 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -82,31 +82,19 @@ public function processNode(Node $node, Scope $scope): array
8282
&& !$leftType->isString()->no()
8383
&& !$rightType->isConstantScalarValue()->yes()
8484
&& !$rightType->isString()->no()
85-
&& TrinaryLogic::extremeIdentity($leftType->isLowercaseString(), $rightType->isLowercaseString())->maybe()
85+
&& (
86+
TrinaryLogic::extremeIdentity($leftType->isLowercaseString(), $rightType->isLowercaseString())->maybe()
87+
|| TrinaryLogic::extremeIdentity($leftType->isUppercaseString(), $rightType->isUppercaseString())->maybe()
88+
)
8689
) || (
8790
$rightType->isConstantScalarValue()->yes()
8891
&& !$rightType->isString()->no()
8992
&& !$leftType->isConstantScalarValue()->yes()
9093
&& !$leftType->isString()->no()
91-
&& TrinaryLogic::extremeIdentity($leftType->isLowercaseString(), $rightType->isLowercaseString())->maybe()
92-
)
93-
) {
94-
$verbosity = VerbosityLevel::precise();
95-
}
96-
97-
if (
98-
(
99-
$leftType->isConstantScalarValue()->yes()
100-
&& !$leftType->isString()->no()
101-
&& !$rightType->isConstantScalarValue()->yes()
102-
&& !$rightType->isString()->no()
103-
&& TrinaryLogic::extremeIdentity($leftType->isUppercaseString(), $rightType->isUppercaseString())->maybe()
104-
) || (
105-
$rightType->isConstantScalarValue()->yes()
106-
&& !$rightType->isString()->no()
107-
&& !$leftType->isConstantScalarValue()->yes()
108-
&& !$leftType->isString()->no()
109-
&& TrinaryLogic::extremeIdentity($leftType->isUppercaseString(), $rightType->isUppercaseString())->maybe()
94+
&& (
95+
TrinaryLogic::extremeIdentity($leftType->isLowercaseString(), $rightType->isLowercaseString())->maybe()
96+
|| TrinaryLogic::extremeIdentity($leftType->isUppercaseString(), $rightType->isUppercaseString())->maybe()
97+
)
11098
)
11199
) {
112100
$verbosity = VerbosityLevel::precise();

0 commit comments

Comments
 (0)