Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream react-native-clean-project to React Native CLI's clean command #113

Open
szymonrybczak opened this issue Nov 6, 2023 · 6 comments

Comments

@szymonrybczak
Copy link

Hey! 👋

I'm maintainer of React Native CLI, and last year we added clean command. react-native-clean-project is great tool, and we would like to upstream all options that RNCP has to clean command, to make it an official solution that will be listed in docs etc.

What do you think about making this tool an official solution? I'll tackle brining all options to RN CLI.

@szymonrybczak
Copy link
Author

cc. @pmadruga

@pmadruga
Copy link
Owner

pmadruga commented Dec 1, 2023

Hey @szymonrybczak that sounds like a good idea. I have a few updates and tweaks to do first, but what would be the next steps?

@szymonrybczak
Copy link
Author

hey @pmadruga 👋

I have a few updates and tweaks to do first

How much work it require? Maybe we can do it directly in CLI?

In the next couple of weeks I'll check what options/feature are not included inside clean command in RN CLI, and then I think I'll create an issue collecting them all - maybe it'll be an umbrella issue, it depends on the amount of the work that needs to be done.

@pmadruga
Copy link
Owner

pmadruga commented Dec 3, 2023

Not a lot of work, it's more a matter of time. The tasks are dependency updates and closing some issues, nothing major.

What would the upstream entail? Will the CLI do a direct reference to RNCP lib?

@szymonrybczak
Copy link
Author

szymonrybczak commented Dec 4, 2023

What would the upstream entail? Will the CLI do a direct reference to RNCP lib?

I think we can merge in checks that are inside RNCP. And add information in RNCP README file that "This tool was upstreamed to React Native CLI, you can use it by running npx react-native clean".

@pmadruga
Copy link
Owner

pmadruga commented Dec 5, 2023

Sounds good. I'll write once I'm done with the updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants