Fix small string compare issue

timothyschoen · timothyschoen · commit 2073e7c03db0 · 2025-08-30T03:58:19.000+02:00
diff --git a/Source/Utility/Containers.h b/Source/Utility/Containers.h
@@ -2942,7 +2942,10 @@ class StackString {
 
     bool operator==(StackString const& other) const
     {
-        return !std::strncmp(data_.data(), other.data_.data(), std::min(data_.size(), other.data_.size()));
+        if(data_.size() != other.data_.size())
+            return false;
+        
+        return !std::strncmp(data_.data(), other.data_.data(), data_.size());
     }
 
     // Returns the number of characters in the string.

Original file line number	Diff line number	Diff line change
`@@ -2942,7 +2942,10 @@ class StackString {`
`2942`	`2942`
`2943`	`2943`	`bool operator==(StackString const& other) const`
`2944`	`2944`	`{`
`2945`		`- return !std::strncmp(data_.data(), other.data_.data(), std::min(data_.size(), other.data_.size()));`
	`2945`	`+ if(data_.size() != other.data_.size())`
	`2946`	`+ return false;`
	`2947`	`+`
	`2948`	`+ return !std::strncmp(data_.data(), other.data_.data(), data_.size());`
`2946`	`2949`	`}`
`2947`	`2950`
`2948`	`2951`	`// Returns the number of characters in the string.`