Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon view from Object browser is missing logic to introduce disabled class #6090

Open
ichim-david opened this issue Jun 10, 2024 · 2 comments
Assignees

Comments

@ichim-david
Copy link
Member

ichim-david commented Jun 10, 2024

In pull request #6054 we received a new object browser view (Icon View)

In the list view which was the previous default if you had an image block on a non image such as a link content type
that item is displayed with a list tag with the class disabled.
See:
choose-image-disabled

This is how the Icon view shows the link content type:
current-album-behavior

Adding the disabled class to the icon view list tag would make the listing look like:
adding-disabled-class

@KUNDAN1334
Copy link

@ichim-david I've identified a way to improve the Icon View in the object browser. We can add a 'disabled' class to non-image items, similar to how it's done in the List View. This would involve modifying the IconViewItem component to check the item type and apply the class accordingly. It's a small change that will enhance visual consistency across views. Would you like me to proceed with implementing this enhancement?

@stevepiercy
Copy link
Collaborator

@KUNDAN1334 please read and follow First-time contributors, especially Things not to do, Contributing to Plone, and Contributing to Volto.

Also it is not necessary to use AI-generated text when making comments. It adds nothing to the discussion, repeating what has already been stated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants