Skip to content

Comment props added by author can collide with props added by the subplebbit #1

@estebanabaroa

Description

@estebanabaroa

In PLIP-0001, it says:

Signature

Subplebbits may add some unsigned fields like comment.depth, comment.previousCid, comment.postCid, etc. these fields must be ignored until validated through commentUpdate.signature and commentUpdate.cid.

This means that if an author decides to add comment.previousCid, then it would collide with a field that the subplebbit needs to add, and the comment would have to be rejected by the subplebbit.

This could be fixed if the subplebbit props were added in comment.subplebbit: SubplebbitProps.

We decided not to do this because it would be more difficult to read and it could cause confusion, like if comment.previousCid and comment.subplebbit.previousCid is defined, which one do you use? which one is more valid than the other?

This might have been a bad decision that will hurt us later, especially if at some point we have another party that needs to add props to the comment, we will see.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions