From 2ea8a77f86b313b02c00561d0251beb7827419b1 Mon Sep 17 00:00:00 2001 From: Minsu Lee Date: Wed, 1 Jul 2026 15:00:01 +0900 Subject: [PATCH 1/3] fix(ci): unblock release pipeline and auto-sync plugin code pins The code-intelligence-lsp plugin runs `code lsp-multiplex`, but the pinned @pleaseai/code@0.1.13 predates that command (added in #100, unreleased), so the LSP server crashed with "Unknown command: lsp-multiplex". Releases were blocked because create-github-app-token had no app credentials. - ci: upgrade create-github-app-token v1 -> v3 and use client-id (recommended input; requires secrets CLIENT_ID and PRIVATE_KEY) - release: auto-bump every plugin's @pleaseai/code pin to the code version on each packages/code release via extra-files json updaters (pins were manual) - plugins: bump code-intelligence-lsp pin to 0.1.14 (the release that ships lsp-multiplex) --- .github/workflows/release-please.yml | 7 ++++--- plugins/code-intelligence-lsp/package.json | 2 +- release-please-config.json | 18 +++++++++++++++++- 3 files changed, 22 insertions(+), 5 deletions(-) diff --git a/.github/workflows/release-please.yml b/.github/workflows/release-please.yml index ee32de5..c4a9051 100644 --- a/.github/workflows/release-please.yml +++ b/.github/workflows/release-please.yml @@ -33,11 +33,12 @@ jobs: release_created: ${{ steps.release.outputs.release_created }} tag_name: ${{ steps.release.outputs.tag_name }} steps: - - uses: actions/create-github-app-token@v1 + - uses: actions/create-github-app-token@v3 id: app-token with: - app-id: ${{ secrets.PF_BOT_APP_ID }} - private-key: ${{ secrets.PF_BOT_PRIVATE_KEY }} + # client-id is the recommended input (supersedes the legacy app-id). + client-id: ${{ secrets.CLIENT_ID }} + private-key: ${{ secrets.PRIVATE_KEY }} - uses: googleapis/release-please-action@v4 id: release diff --git a/plugins/code-intelligence-lsp/package.json b/plugins/code-intelligence-lsp/package.json index de841d3..dba2150 100644 --- a/plugins/code-intelligence-lsp/package.json +++ b/plugins/code-intelligence-lsp/package.json @@ -1,6 +1,6 @@ { "private": true, "dependencies": { - "@pleaseai/code": "0.1.13" + "@pleaseai/code": "0.1.14" } } diff --git a/release-please-config.json b/release-please-config.json index 2e0ccb7..79ab07c 100644 --- a/release-please-config.json +++ b/release-please-config.json @@ -65,7 +65,23 @@ }, "packages/code": { "release-type": "node", - "component": "@pleaseai/code" + "component": "@pleaseai/code", + "extra-files": [ + { "type": "json", "path": "plugins/clangd-lsp/package.json", "jsonpath": "$.dependencies['@pleaseai/code']" }, + { "type": "json", "path": "plugins/code-intelligence-lsp/package.json", "jsonpath": "$.dependencies['@pleaseai/code']" }, + { "type": "json", "path": "plugins/csharp-lsp/package.json", "jsonpath": "$.dependencies['@pleaseai/code']" }, + { "type": "json", "path": "plugins/dart-lsp/package.json", "jsonpath": "$.dependencies['@pleaseai/code']" }, + { "type": "json", "path": "plugins/elixir-lsp/package.json", "jsonpath": "$.dependencies['@pleaseai/code']" }, + { "type": "json", "path": "plugins/eslint-lsp/package.json", "jsonpath": "$.dependencies['@pleaseai/code']" }, + { "type": "json", "path": "plugins/fsharp-lsp/package.json", "jsonpath": "$.dependencies['@pleaseai/code']" }, + { "type": "json", "path": "plugins/jdtls-lsp/package.json", "jsonpath": "$.dependencies['@pleaseai/code']" }, + { "type": "json", "path": "plugins/kotlin-lsp/package.json", "jsonpath": "$.dependencies['@pleaseai/code']" }, + { "type": "json", "path": "plugins/lua-lsp/package.json", "jsonpath": "$.dependencies['@pleaseai/code']" }, + { "type": "json", "path": "plugins/rubocop-lsp/package.json", "jsonpath": "$.dependencies['@pleaseai/code']" }, + { "type": "json", "path": "plugins/terraform-lsp/package.json", "jsonpath": "$.dependencies['@pleaseai/code']" }, + { "type": "json", "path": "plugins/texlab-lsp/package.json", "jsonpath": "$.dependencies['@pleaseai/code']" }, + { "type": "json", "path": "plugins/zls-lsp/package.json", "jsonpath": "$.dependencies['@pleaseai/code']" } + ] }, "packages/dora": { "release-type": "node", From 2d2d99fd1eed59a33f629d3ab17a39b183cf0a0d Mon Sep 17 00:00:00 2001 From: Minsu Lee Date: Wed, 1 Jul 2026 15:23:33 +0900 Subject: [PATCH 2/3] =?UTF-8?q?chore(ci):=20apply=20review=20=E2=80=94=20s?= =?UTF-8?q?cope=20app-token=20secret=20names,=20use=20vars=20for=20client-?= =?UTF-8?q?id?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .github/workflows/release-please.yml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/release-please.yml b/.github/workflows/release-please.yml index c4a9051..8a60145 100644 --- a/.github/workflows/release-please.yml +++ b/.github/workflows/release-please.yml @@ -37,8 +37,9 @@ jobs: id: app-token with: # client-id is the recommended input (supersedes the legacy app-id). - client-id: ${{ secrets.CLIENT_ID }} - private-key: ${{ secrets.PRIVATE_KEY }} + # client-id is a public identifier -> repo/org variable; only the key is secret. + client-id: ${{ vars.RELEASE_BOT_CLIENT_ID }} + private-key: ${{ secrets.RELEASE_BOT_PRIVATE_KEY }} - uses: googleapis/release-please-action@v4 id: release From eea974415cc57c2a110f44b9872ebd33438e56ef Mon Sep 17 00:00:00 2001 From: Minsu Lee Date: Wed, 1 Jul 2026 16:10:06 +0900 Subject: [PATCH 3/3] fix(ci): match app-token vars to provisioned RELEASE_GITHUB_APP_* names --- .github/workflows/release-please.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/release-please.yml b/.github/workflows/release-please.yml index 8a60145..1d45654 100644 --- a/.github/workflows/release-please.yml +++ b/.github/workflows/release-please.yml @@ -38,8 +38,8 @@ jobs: with: # client-id is the recommended input (supersedes the legacy app-id). # client-id is a public identifier -> repo/org variable; only the key is secret. - client-id: ${{ vars.RELEASE_BOT_CLIENT_ID }} - private-key: ${{ secrets.RELEASE_BOT_PRIVATE_KEY }} + client-id: ${{ vars.RELEASE_GITHUB_APP_CLIENT_ID }} + private-key: ${{ secrets.RELEASE_GITHUB_APP_PRIVATE_KEY }} - uses: googleapis/release-please-action@v4 id: release